Move stats collection of eNB stats into s1ap thread#7758
Merged
amarpad merged 1 commit intomagma:masterfrom Jun 25, 2021
Merged
Move stats collection of eNB stats into s1ap thread#7758amarpad merged 1 commit intomagma:masterfrom
amarpad merged 1 commit intomagma:masterfrom
Conversation
pull-request-size
bot
added
the
size/L
Contributor
|
Thanks for opening a PR! 💯 Please note that all commits must be signed off. This is enforced by the Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
amarpad
commented
Jun 24, 2021
| case APPLICATION_MME_APP_STATS_MSG: { | ||
| service303_mme_app_statistics_read( | ||
| &received_message_p->ittiMsg.application_mme_app_stats_msg); | ||
| } break; |
Contributor
Author
There was a problem hiding this comment.
@ulaskozat , @themarwhal : Oversight on missing the break here, so the first sample gets recorded correctly but subsequent samples don't as the thread exists. Apologies.
Contributor
|
Can you move stats printing in debug mode from mme app to 303 as it has now all the stats? |
Contributor
Author
I think that is a separate cleanup. This is a correctness fix. |
The current access pattern violates the ITTI framework so 1 - Create a stats timer for S1ap to send stats to service303 2 - Remove fields from mme_app structure relating to eNB (s1). 3 - Move the increment of enb stats to post s1setup request vs when the association gets enabled. This makes more sense and maps to where the increment used to happen for the cross thread stats Also was missing a break for handling APPLICATION_MME_APP_STATS_MSG which triggered the premature termination of the service303 thread, regression introduced in by me in 118e113. Fixed that as well. Signed-off-by: Amar Padmanabhan <[email protected]>
themarwhal
pushed a commit
that referenced
this pull request
Jun 25, 2021
The current access pattern violates the ITTI framework so 1 - Create a stats timer for S1ap to send stats to service303 2 - Remove fields from mme_app structure relating to eNB (s1). 3 - Move the increment of enb stats to post s1setup request vs when the association gets enabled. This makes more sense and maps to where the increment used to happen for the cross thread stats Also was missing a break for handling APPLICATION_MME_APP_STATS_MSG which triggered the premature termination of the service303 thread, regression introduced in by me in 118e113. Fixed that as well. Signed-off-by: Amar Padmanabhan <[email protected]> Co-authored-by: Amar Padmanabhan <[email protected]>
rmeleromira
pushed a commit
to rmeleromira/magma
that referenced
this pull request
Jul 24, 2021
The current access pattern violates the ITTI framework so 1 - Create a stats timer for S1ap to send stats to service303 2 - Remove fields from mme_app structure relating to eNB (s1). 3 - Move the increment of enb stats to post s1setup request vs when the association gets enabled. This makes more sense and maps to where the increment used to happen for the cross thread stats Also was missing a break for handling APPLICATION_MME_APP_STATS_MSG which triggered the premature termination of the service303 thread, regression introduced in by me in 118e113. Fixed that as well. Signed-off-by: Amar Padmanabhan <[email protected]> Co-authored-by: Amar Padmanabhan <[email protected]> Signed-off-by: Ramon Melero <[email protected]>
This was referenced Jul 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The current access pattern violates the ITTI framework so
1 - Create a stats timer for S1ap to send stats to service303
2 - Remove fields from mme_app structure relating to eNB (s1).
3 - Move the increment of enb stats to post s1setup request vs when the
association gets enabled. This makes more sense and maps to where the
increment used to happen for the cross thread stats
Also was missing a break for handling APPLICATION_MME_APP_STATS_MSG which
triggered the premature termination of the service303 thread, regression
introduced in by me in 118e113. Fixed that as well.
Test Plan
1 - Added instrumentation logs to validate that the timer was getting triggered multiple times
2 - make integ_test (on debian)
Additional Information