Skip to content

[NMS] Fix NMS placeholder for HE#7705

Merged
karthiksubraveti merged 1 commit intomagma:masterfrom
karthiksubraveti:nms_minor_fix.0
Jun 22, 2021
Merged

[NMS] Fix NMS placeholder for HE#7705
karthiksubraveti merged 1 commit intomagma:masterfrom
karthiksubraveti:nms_minor_fix.0

Conversation

@karthiksubraveti
Copy link
Copy Markdown
Contributor

Signed-off-by: Karthik Subraveti [email protected]

Summary

Test Plan

Additional Information

  • This change is backwards-breaking

Signed-off-by: Karthik Subraveti <[email protected]>
@karthiksubraveti karthiksubraveti requested review from a team and andreilee June 22, 2021 16:32
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Jun 22, 2021
@github-actions
Copy link
Copy Markdown
Contributor

Thanks for opening a PR! 💯 Please note that all commits must be signed off. This is enforced by the DCO check.

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@sudhikan
Copy link
Copy Markdown
Contributor

cc: @pshelar

@karthiksubraveti karthiksubraveti added apply-v1.5 Apply this commit to the v1.5 release branch as well. apply-v1.6 labels Jun 22, 2021
@karthiksubraveti karthiksubraveti enabled auto-merge (squash) June 22, 2021 16:35
Copy link
Copy Markdown
Contributor

@pshelar pshelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@karthiksubraveti karthiksubraveti merged commit 70f14bb into magma:master Jun 22, 2021
themarwhal pushed a commit that referenced this pull request Jun 22, 2021
Signed-off-by: Karthik Subraveti <[email protected]>
themarwhal pushed a commit that referenced this pull request Jun 22, 2021
Signed-off-by: Karthik Subraveti <[email protected]>
rmeleromira pushed a commit to rmeleromira/magma that referenced this pull request Jul 24, 2021
Signed-off-by: Karthik Subraveti <[email protected]>
Signed-off-by: Ramon Melero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apply-v1.5 Apply this commit to the v1.5 release branch as well. apply-v1.6 backported-v1.5 backported-v1.6 size/XS Denotes a PR that changes 0-9 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants