Skip to content

[feg] add Service Identifier to CCR-U#7616

Merged
uri200 merged 1 commit intomagma:masterfrom
uri200:feg_session_proxy_fix_service_identifier_avp
Jun 17, 2021
Merged

[feg] add Service Identifier to CCR-U#7616
uri200 merged 1 commit intomagma:masterfrom
uri200:feg_session_proxy_fix_service_identifier_avp

Conversation

@uri200
Copy link
Copy Markdown
Contributor

@uri200 uri200 commented Jun 17, 2021

Signed-off-by: Oriol Batalla [email protected]

Summary

Service identifier field was not being sent on CCRU

Test Plan

make precommit
Terravm test
image

Additional Information

  • This change is backwards-breaking

@uri200 uri200 requested review from a team and emakeev June 17, 2021 03:26
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label Jun 17, 2021
@github-actions
Copy link
Copy Markdown
Contributor

Thanks for opening a PR! 💯 Please note that all commits must be signed off. This is enforced by the DCO check.

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@uri200 uri200 force-pushed the feg_session_proxy_fix_service_identifier_avp branch from b117a0a to 6bf074d Compare June 17, 2021 03:31
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 17, 2021

Codecov Report

Merging #7616 (6bf074d) into master (4b8bc00) will increase coverage by 0.01%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7616      +/-   ##
==========================================
+ Coverage   64.43%   64.45%   +0.01%     
==========================================
  Files         680      680              
  Lines       47037    47041       +4     
  Branches     1323     1323              
==========================================
+ Hits        30307    30318      +11     
+ Misses      13272    13266       -6     
+ Partials     3458     3457       -1     
Flag Coverage Δ
cloud_lint 65.73% <ø> (+0.01%) ⬆️
feg-lint 56.40% <90.00%> (+0.03%) ⬆️
lte-test 72.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ession_proxy/credit_control/gy/model_conversion.go 93.18% <90.00%> (-1.82%) ⬇️
...vices/session_proxy/credit_control/gy/gy_client.go 66.21% <0.00%> (+1.36%) ⬆️
...oud/go/services/state/indexer/reindex/reindexer.go 68.62% <0.00%> (+1.96%) ⬆️
feg/gateway/policydb/streamer.go 47.82% <0.00%> (+8.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b8bc00...6bf074d. Read the comment docs.

@uri200 uri200 merged commit 26bb107 into magma:master Jun 17, 2021
themarwhal pushed a commit that referenced this pull request Jun 18, 2021
rmeleromira pushed a commit to rmeleromira/magma that referenced this pull request Jul 24, 2021
Signed-off-by: Oriol Batalla <[email protected]>
Signed-off-by: Ramon Melero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apply-v1.6 backported-v1.6 size/M Denotes a PR that changes 30-99 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Magma NMS/FeG] Mapping Service Identifier with Rating group for CCR-I to OCS

2 participants