[feg] s8_proxy fix wrong mnc on ULI#7549
Merged
uri200 merged 1 commit intomagma:masterfrom Jun 16, 2021
Merged
Conversation
Contributor
|
Thanks for opening a PR! 💯 Please note that all commits must be signed off. This is enforced by the Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
themarwhal
approved these changes
Jun 15, 2021
Codecov Report
@@ Coverage Diff @@
## master #7549 +/- ##
==========================================
- Coverage 64.44% 64.43% -0.01%
==========================================
Files 680 680
Lines 47024 47032 +8
Branches 1323 1323
==========================================
+ Hits 30303 30307 +4
- Misses 13265 13268 +3
- Partials 3456 3457 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
1 task
Signed-off-by: Oriol Batalla <[email protected]>
rmeleromira
pushed a commit
to rmeleromira/magma
that referenced
this pull request
Jul 24, 2021
Signed-off-by: Oriol Batalla <[email protected]> Signed-off-by: Ramon Melero <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Oriol Batalla [email protected]
Summary
Update Location Information on create session request at s8 was sending wrong MCC (in fact it was sending MNC two times).
This PR fixes that and adds some unit test to prevents future issues like this
Test Plan
make precommit at feg
Additional Information