Skip to content

[orc8r] add service indicator to PolicyRules on swagger#7545

Merged
uri200 merged 1 commit intomagma:masterfrom
uri200:orc8r_add_service_indicator_to_static_policies
Jun 15, 2021
Merged

[orc8r] add service indicator to PolicyRules on swagger#7545
uri200 merged 1 commit intomagma:masterfrom
uri200:orc8r_add_service_indicator_to_static_policies

Conversation

@uri200
Copy link
Copy Markdown
Contributor

@uri200 uri200 commented Jun 14, 2021

Signed-off-by: Oriol Batalla [email protected]

Summary

Added service_indication to policies stored on policydb

Test Plan

./build.py g
make precommit at or8cr

Additional Information

  • This change is backwards-breaking

@uri200 uri200 requested review from a team and emakeev June 14, 2021 23:10
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label Jun 14, 2021
@github-actions
Copy link
Copy Markdown
Contributor

Thanks for opening a PR! 💯 Please note that all commits must be signed off. This is enforced by the DCO check.

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@magmabot magmabot added the component: agw Access gateway-related issue label Jun 14, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 14, 2021

Codecov Report

Merging #7545 (d5849e9) into master (fa8e444) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7545      +/-   ##
==========================================
- Coverage   64.44%   64.44%   -0.01%     
==========================================
  Files         680      680              
  Lines       47024    47028       +4     
  Branches     1323     1323              
==========================================
+ Hits        30303    30305       +2     
- Misses      13265    13266       +1     
- Partials     3456     3457       +1     
Flag Coverage Δ
cloud_lint 65.72% <50.00%> (-0.01%) ⬇️
feg-lint 56.38% <ø> (ø)
lte-test 72.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...go/services/policydb/obsidian/models/conversion.go 86.19% <50.00%> (-0.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa8e444...d5849e9. Read the comment docs.

@uri200 uri200 merged commit 15d3c50 into magma:master Jun 15, 2021
@uri200 uri200 deleted the orc8r_add_service_indicator_to_static_policies branch June 15, 2021 00:37
rmeleromira pushed a commit to rmeleromira/magma that referenced this pull request Jul 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: agw Access gateway-related issue size/M Denotes a PR that changes 30-99 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Magma NMS/FeG] Mapping Service Identifier with Rating group for CCR-I to OCS

3 participants