perf(pipeilined): Remove rule map entry in rule Deactivate call#7539
Merged
pshelar merged 1 commit intomagma:masterfrom Jun 14, 2021
Merged
perf(pipeilined): Remove rule map entry in rule Deactivate call#7539pshelar merged 1 commit intomagma:masterfrom
pshelar merged 1 commit intomagma:masterfrom
Conversation
Contributor
|
Thanks for opening a PR! 💯 Please note that all commits must be signed off. This is enforced by the Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
koolzz
approved these changes
Jun 14, 2021
Contributor
koolzz
left a comment
koolzz
left a comment
There was a problem hiding this comment.
lgtm, I think with the new save/version from sessiond this is a safe change. @themarwhal just tagging you here for reference
Member
This seems safe I think. When we delete the rules, we probably don't care about the version anymore in PipelineD. |
pipelined updates version of the rule on Deactivate call. This could result in lower performance is case of higher number of UEs. Deleting the entry improves performance and has same result. Signed-off-by: Pravin B Shelar <[email protected]>
pshelar
force-pushed
the
use-del-for-update_all_ue_versions
branch
from
e4523ee to
f59af86
Compare
pshelar
added
the
apply-v1.5
themarwhal
pushed a commit
that referenced
this pull request
Jun 17, 2021
pipelined updates version of the rule on Deactivate call. This could result in lower performance is case of higher number of UEs. Deleting the entry improves performance and has same result. Signed-off-by: Pravin B Shelar <[email protected]>
rmeleromira
pushed a commit
to rmeleromira/magma
that referenced
this pull request
Jul 24, 2021
…a#7539) pipelined updates version of the rule on Deactivate call. This could result in lower performance is case of higher number of UEs. Deleting the entry improves performance and has same result. Signed-off-by: Pravin B Shelar <[email protected]> Signed-off-by: Ramon Melero <[email protected]>
m-trojanowski
pushed a commit
to openEPC/magma
that referenced
this pull request
Oct 20, 2021
…a#7539) pipelined updates version of the rule on Deactivate call. This could result in lower performance is case of higher number of UEs. Deleting the entry improves performance and has same result. Signed-off-by: Pravin B Shelar <[email protected]>
m-trojanowski
pushed a commit
to openEPC/magma
that referenced
this pull request
Oct 20, 2021
…a#7539) pipelined updates version of the rule on Deactivate call. This could result in lower performance is case of higher number of UEs. Deleting the entry improves performance and has same result. Signed-off-by: Pravin B Shelar <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pipelined updates version of the rule on Deactivate call. This could
result in lower performance is case of higher number of UEs.
Deleting the entry improves performance and has same result.
Signed-off-by: Pravin B Shelar [email protected]
Summary
Test Plan
make testAdditional Information