Merged
Conversation
Signed-off-by: Nick Yurchenko <[email protected]>
Contributor
|
Thanks for opening a PR! 💯 Please note that all commits must be signed off. This is enforced by the Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
pshelar
reviewed
Jun 7, 2021
| flags=0x1, | ||
| zone_src=None, | ||
| zone_ofs_nbits=ofs_nbits(14, 15), | ||
| zone_ofs_nbits=self.zone, |
Contributor
There was a problem hiding this comment.
I am not sure about this.
the zone_src is reg and zone_ofs_nbits bits to copy from that reg.
am I missing something?
Contributor
Author
There was a problem hiding this comment.
The flows seem to be installed correctly I've ran the test_conntrack.py test
I think if zone_src is None its set by the zone_ofs_nbits as said here
zone_ofs_nbits | Start and End for the OXM/NXM field. Setting method refer to the nicira_ext.ofs_nbits. If you need set the Immediate value for zone, zone_src must be set to None or empty character string.
pshelar
approved these changes
Jun 7, 2021
Signed-off-by: Nick Yurchenko <[email protected]>
koolzz
force-pushed
the
fix_conntrackd_zone_verification
branch
from
cc3ee01 to
bf6cbfd
Compare
themarwhal
pushed a commit
that referenced
this pull request
Jun 7, 2021
* Add zone match to conntrackd Signed-off-by: Nick Yurchenko <[email protected]> * Fix conntrack zone on pipelined Signed-off-by: Nick Yurchenko <[email protected]>
rmeleromira
pushed a commit
to rmeleromira/magma
that referenced
this pull request
Jul 24, 2021
* Add zone match to conntrackd Signed-off-by: Nick Yurchenko <[email protected]> * Fix conntrack zone on pipelined Signed-off-by: Nick Yurchenko <[email protected]> Signed-off-by: Ramon Melero <[email protected]>
m-trojanowski
pushed a commit
to openEPC/magma
that referenced
this pull request
Oct 20, 2021
* Add zone match to conntrackd Signed-off-by: Nick Yurchenko <[email protected]> * Fix conntrack zone on pipelined Signed-off-by: Nick Yurchenko <[email protected]>
m-trojanowski
pushed a commit
to openEPC/magma
that referenced
this pull request
Oct 20, 2021
* Add zone match to conntrackd Signed-off-by: Nick Yurchenko <[email protected]> * Fix conntrack zone on pipelined Signed-off-by: Nick Yurchenko <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Instead of checking all conntrackd events only check those which match the zone set by ovs
Test Plan
Checked logs when running conntrack pipelined test, works as expected
Additional Information