Skip to content

AGW: ubuntu: deploy: support static IP based SGi interface on AGW#6832

Merged
pshelar merged 1 commit intomagma:masterfrom
pshelar:ub-deploy-static-ip1
May 11, 2021
Merged

AGW: ubuntu: deploy: support static IP based SGi interface on AGW#6832
pshelar merged 1 commit intomagma:masterfrom
pshelar:ub-deploy-static-ip1

Conversation

@pshelar
Copy link
Copy Markdown
Contributor

@pshelar pshelar commented May 7, 2021

Following install file changes allows AGW installation
on server with SGi which has statically allocated IP address.

Signed-off-by: Pravin B Shelar [email protected]

Summary

Test Plan

validated on virtual agw.
shellcheck

Additional Information

  • This change is backwards-breaking

@pshelar pshelar requested a review from a team as a code owner May 7, 2021 17:50
@pshelar pshelar requested a review from koolzz May 7, 2021 17:50
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label May 7, 2021
@magmabot magmabot added the component: agw Access gateway-related issue label May 7, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented May 7, 2021

Codecov Report

Merging #6832 (c4e8777) into master (d5703b2) will increase coverage by 31.37%.
The diff coverage is n/a.

❗ Current head c4e8777 differs from pull request most recent head e1eff18. Consider uploading reports for the commit e1eff18 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #6832       +/-   ##
===========================================
+ Coverage   33.16%   64.54%   +31.37%     
===========================================
  Files        1151      666      -485     
  Lines      103262    45891    -57371     
  Branches     1318     1318               
===========================================
- Hits        34252    29621     -4631     
+ Misses      65638    12898    -52740     
  Partials     3372     3372               
Flag Coverage Δ
c_cpp ?
cloud_lint 65.68% <ø> (ø)
feg-lint 56.55% <ø> (ø)
lte-test 72.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...y/c/oai/tasks/nas/esm/msg/EsmInformationResponse.c
.../c/oai/tasks/nas5g/src/M5GRegistrationComplete.cpp
lte/gateway/c/oai/tasks/nas/emm/msg/AttachReject.c
lte/gateway/c/oai/tasks/nas/esm/esm_ip.c
lte/gateway/c/oai/tasks/nas/ies/ShortMac.c
lte/gateway/c/session_manager/MemoryStoreClient.h
...teway/c/oai/tasks/nas/ies/EpsBearerContextStatus.c
lte/gateway/c/session_manager/CreditKey.h
lte/gateway/c/oai/lib/n11/SmfServiceClient.cpp
lte/gateway/c/oai/tasks/sgw/sgw_context_manager.c
... and 475 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5703b2...e1eff18. Read the comment docs.

@pshelar pshelar force-pushed the ub-deploy-static-ip1 branch 2 times, most recently from e1eff18 to a9e23f0 Compare May 10, 2021 22:41
Following install file changes allows AGW installation,
on server with SGi which has statically allocated IP address.

Signed-off-by: Pravin B Shelar <[email protected]>
@pshelar pshelar force-pushed the ub-deploy-static-ip1 branch from a9e23f0 to 70bae6d Compare May 11, 2021 17:21
@pshelar pshelar merged commit cc0e814 into magma:master May 11, 2021
@pshelar pshelar added the apply-v1.5 Apply this commit to the v1.5 release branch as well. label May 12, 2021
themarwhal pushed a commit that referenced this pull request May 12, 2021
Following install file changes allows AGW installation,
on server with SGi which has statically allocated IP address.

Signed-off-by: Pravin B Shelar <[email protected]>
m-trojanowski pushed a commit to openEPC/magma that referenced this pull request Oct 20, 2021
Following install file changes allows AGW installation,
on server with SGi which has statically allocated IP address.

Signed-off-by: Pravin B Shelar <[email protected]>
m-trojanowski pushed a commit to openEPC/magma that referenced this pull request Oct 20, 2021
Following install file changes allows AGW installation,
on server with SGi which has statically allocated IP address.

Signed-off-by: Pravin B Shelar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apply-v1.5 Apply this commit to the v1.5 release branch as well. backported-v1.5 component: agw Access gateway-related issue size/M Denotes a PR that changes 30-99 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants