Skip to content

[lte][agw] Accept eNB-initiated Reset from eNBs without UEs associated#6808

Merged
ulaskozat merged 1 commit intomagma:masterfrom
shaddi:ho_reset
May 12, 2021
Merged

[lte][agw] Accept eNB-initiated Reset from eNBs without UEs associated#6808
ulaskozat merged 1 commit intomagma:masterfrom
shaddi:ho_reset

Conversation

@shaddi
Copy link
Copy Markdown
Contributor

@shaddi shaddi commented May 6, 2021

Summary

Accept eNB-initiated Reset procedures from eNBs, even when the MME isn't aware of any UEs associated with that eNB. This can happen during handover, or if the eNB has gotten into a bad state. Although this should not actually clean up any state on the MME, some eNodeBs seem to expect an acknowledgement and failing to send one prevents UEs from re-attaching. Closes #6781.

Signed-off-by: Shaddi Hasan [email protected]

Test Plan

Testing on CBRS testbed @ MPK
Integ tests

@shaddi shaddi requested review from a team, ardzoht and ulaskozat May 6, 2021 19:32
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines. label May 6, 2021
@magmabot magmabot added the component: agw Access gateway-related issue label May 6, 2021
Comment thread lte/gateway/c/oai/tasks/s1ap/s1ap_mme_handlers.c Outdated
Accept eNB-initiated Reset procedures from eNBs, even when the MME isn't
aware of any eNBs associated with that eNB. This can happen during
handover, or if the eNB has gotten into a bad state. Although this
should not actually clean up any state on the MME, some eNodeBs seem to
expect an acknowledgement and failing to send one prevents UEs from
re-attaching. Closes magma#6781.

Signed-off-by: Shaddi Hasan <[email protected]>
Copy link
Copy Markdown
Contributor

@ardzoht ardzoht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ulaskozat
Copy link
Copy Markdown
Contributor

@shaddi, @sudhikan is this tested on CBRS testbed? @rsarwad I see a note has been removed that suggests that an error indication should be sent. Can you double check on the spec what needs to be done in this case?

@shaddi
Copy link
Copy Markdown
Contributor Author

shaddi commented May 11, 2021

Yes, @sudhikan has tested this on the CBRS testbed. According to TS36.413, the Reset procedure can occur at any time and takes precedence over any other procedures. To my knowledge, the behavior of the MME when receiving a Reset for an unknown association is not defined. Specifically, 8.7.1.3 only defines abnormal conditions for Reset when certain IEs are missing from the reset message, which is not the case here, so I think ignoring the Reset (as we're currently doing) is actually violating the spec.

@rsarwad
Copy link
Copy Markdown
Contributor

rsarwad commented May 12, 2021

Hi @ulaskozat I agree with @shaddi As per 36.413 section 8.7.1.3 , On reception of Reset message at mme, even if no s1 signaling connection exists for the received eNB/MME s1ap id pair; mme needs send Reset ack with whatever UE-associated logical S1-connections are received in Reset message.
The TBD note has been existing from legacy OAI code

Copy link
Copy Markdown
Contributor

@ulaskozat ulaskozat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ulaskozat ulaskozat merged commit 3e01a81 into magma:master May 12, 2021
@ulaskozat ulaskozat added apply-v1.4 Needs to be applied to v1.4 release branch as well apply-v1.5 Apply this commit to the v1.5 release branch as well. labels May 12, 2021
themarwhal pushed a commit that referenced this pull request May 12, 2021
Accept eNB-initiated Reset procedures from eNBs, even when the MME isn't
aware of any eNBs associated with that eNB. This can happen during
handover, or if the eNB has gotten into a bad state. Although this
should not actually clean up any state on the MME, some eNodeBs seem to
expect an acknowledgement and failing to send one prevents UEs from
re-attaching. Closes #6781.

Signed-off-by: Shaddi Hasan <[email protected]>
@themarwhal themarwhal added the backported-v1.4 Has been backported to v1.4 release branch label May 12, 2021
themarwhal pushed a commit that referenced this pull request May 12, 2021
Accept eNB-initiated Reset procedures from eNBs, even when the MME isn't
aware of any eNBs associated with that eNB. This can happen during
handover, or if the eNB has gotten into a bad state. Although this
should not actually clean up any state on the MME, some eNodeBs seem to
expect an acknowledgement and failing to send one prevents UEs from
re-attaching. Closes #6781.

Signed-off-by: Shaddi Hasan <[email protected]>
m-trojanowski pushed a commit to openEPC/magma that referenced this pull request Oct 20, 2021
)

Accept eNB-initiated Reset procedures from eNBs, even when the MME isn't
aware of any eNBs associated with that eNB. This can happen during
handover, or if the eNB has gotten into a bad state. Although this
should not actually clean up any state on the MME, some eNodeBs seem to
expect an acknowledgement and failing to send one prevents UEs from
re-attaching. Closes magma#6781.

Signed-off-by: Shaddi Hasan <[email protected]>
m-trojanowski pushed a commit to openEPC/magma that referenced this pull request Oct 20, 2021
)

Accept eNB-initiated Reset procedures from eNBs, even when the MME isn't
aware of any eNBs associated with that eNB. This can happen during
handover, or if the eNB has gotten into a bad state. Although this
should not actually clean up any state on the MME, some eNodeBs seem to
expect an acknowledgement and failing to send one prevents UEs from
re-attaching. Closes magma#6781.

Signed-off-by: Shaddi Hasan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apply-v1.4 Needs to be applied to v1.4 release branch as well apply-v1.5 Apply this commit to the v1.5 release branch as well. backported-v1.4 Has been backported to v1.4 release branch backported-v1.5 component: agw Access gateway-related issue size/S Denotes a PR that changes 10-29 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[1.5] S1AP Reset messages should be acknowledged by the MME

6 participants