Skip to content

[lte][agw] Error indication handling#5956

Merged
ulaskozat merged 4 commits intomagma:masterfrom
ulaskozat:error_indication
Apr 7, 2021
Merged

[lte][agw] Error indication handling#5956
ulaskozat merged 4 commits intomagma:masterfrom
ulaskozat:error_indication

Conversation

@ulaskozat
Copy link
Copy Markdown
Contributor

@ulaskozat ulaskozat commented Apr 6, 2021

Summary

  • PR extends the support of error indication handling for addressing unknown pair of UE S1AP ID. We trigger a context release request for matching MME UE S1AP ID that also leads to implicit detach for unregistered UEs.
  • A minor refactoring on sending the context release request is done.

Test Plan

Integ tests for regression. S1AP support will be added to cover error indication signals in another PR once S1AP Tester itself is updated.

Spirent tests are conducted, where the issue is observed with at scale tests.

Before changes, we had:

400288 Fri Apr 02 23:30:35 2021 7F495A3D9700 WARNI S1AP   tasks/s1ap/s1ap_mme_handlers.c  :2529    ERROR IND RCVD on Stream id 1, ignoring it

After changes, an example of this handling:

189784 Mon Apr 05 21:37:18 2021 7F50021D6700 WARNI S1AP   tasks/s1ap/s1ap_mme_handlers.c  :2514    ERROR IND RCVD on Stream id 1 
189785 Mon Apr 05 21:37:18 2021 7F50059DD700 ERROR MME-AP tasks/mme_app/mme_app_context.c :2005   [1011234560372] UE context release request received while UE is in Deregistered state Perform implicit detach for ue-id0x00003FE7

Additional Information

  • This change is backwards-breaking

@pull-request-size pull-request-size bot added the size/L Denotes a Pull Request that changes 100-499 lines. label Apr 6, 2021
@magmabot magmabot added the component: agw Access gateway-related issue label Apr 6, 2021
Copy link
Copy Markdown
Contributor

@ardzoht ardzoht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Contributor

@talkhasib talkhasib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits

}

if ((ue_ref_p = s1ap_state_get_ue_mmeid((uint32_t) mme_ue_s1ap_id)) == NULL) {
OAILOG_INFO(
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be warning level?

Comment thread lte/gateway/c/oai/tasks/s1ap/s1ap_mme_handlers.c
Signed-off-by: Ulas Kozat <[email protected]>
@ulaskozat ulaskozat merged commit dd2e2a1 into magma:master Apr 7, 2021
@ulaskozat ulaskozat deleted the error_indication branch April 7, 2021 00:27
@ulaskozat ulaskozat added the apply-v1.4 Needs to be applied to v1.4 release branch as well label Apr 8, 2021
@tmdzk tmdzk removed the apply-v1.4 Needs to be applied to v1.4 release branch as well label Apr 15, 2021
ulaskozat added a commit to ulaskozat/magma that referenced this pull request Apr 15, 2021
* Add support for s1ap error indication message

Signed-off-by: Ulas Kozat <[email protected]>
ulaskozat added a commit that referenced this pull request Apr 19, 2021
* Add support for s1ap error indication message

Signed-off-by: Ulas Kozat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: agw Access gateway-related issue size/L Denotes a Pull Request that changes 100-499 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants