[lte][agw] Eliminate some of the unnecessary state syncs on s1ap#5888
Merged
ulaskozat merged 1 commit intomagma:masterfrom Apr 5, 2021
Merged
[lte][agw] Eliminate some of the unnecessary state syncs on s1ap#5888ulaskozat merged 1 commit intomagma:masterfrom
ulaskozat merged 1 commit intomagma:masterfrom
Conversation
Signed-off-by: Ulas Kozat <[email protected]>
ardzoht
approved these changes
Apr 2, 2021
Contributor
ardzoht
left a comment
ardzoht
left a comment
There was a problem hiding this comment.
minor comment, overall lgtm
| state = get_s1ap_state(false); | ||
| AssertFatal(state != NULL, "failed to retrieve s1ap state (was null)"); | ||
|
|
||
| bool is_state_same = false; |
Contributor
There was a problem hiding this comment.
minor nit: I feel has_state_changed is a better name for this, and it should reduce the number of the value being set to true
Contributor
Author
There was a problem hiding this comment.
@ardzoht I want to have the default behavior to sync the state and explicitly call out the ones that do not modify the state (at all or most of the time). This will be more robust against new additions to the code base (e.g., s1 mobility).
chandra-77
pushed a commit
to chandra-77/magma
that referenced
this pull request
Apr 6, 2021
Signed-off-by: Ulas Kozat <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Each message handling by default triggers state synchronization service on S1AP task. This PR eliminates such syncs for the subset of S1AP handled messages that does not make any state modifications. This is complementary to the PR #5868.
Test Plan
Integration tests for regression.
Spirent tests for performance. Attached below 3 iterations with 500 UEs, 5 UE/sec attach rate, 500kbps per UE traffic.
Additional Information