Skip to content

[lte][agw] Add hash-based validation to reduce redis writes operations on MME#5868

Merged
ardzoht merged 3 commits intomagma:masterfrom
ardzoht:reduce_redis_client_writes_ops
Apr 2, 2021
Merged

[lte][agw] Add hash-based validation to reduce redis writes operations on MME#5868
ardzoht merged 3 commits intomagma:masterfrom
ardzoht:reduce_redis_client_writes_ops

Conversation

@ardzoht
Copy link
Copy Markdown
Contributor

@ardzoht ardzoht commented Apr 1, 2021 •
edited
Loading

Summary

  • Adds hash computation based on contents of serialized proto message for redis_client for task state, ue context and s1ap imsi map values
  • Checks if last written proto hash value is different from next to be written, if it's equal, skips write operation
  • Remove read state proto to check last version on write, instead keep track of it on state_manager as member value

Test Plan

  • make integ test as sanity and continuous attach test
  • tested on spirent as performance and load test validation

Additional Information

  • This change is backwards-breaking

@pull-request-size pull-request-size bot added the size/L Denotes a Pull Request that changes 100-499 lines. label Apr 1, 2021
@magmabot magmabot added the component: agw Access gateway-related issue label Apr 1, 2021
@ardzoht ardzoht linked an issue Apr 1, 2021 that may be closed by this pull request
[lte][agw] Hash-based versioning and validation to reduce write operations on MME #5573
Closed
ulaskozat
ulaskozat reviewed Apr 1, 2021
View reviewed changes
Comment thread lte/gateway/c/oai/include/state_manager.h Outdated
ulaskozat
ulaskozat reviewed Apr 1, 2021
View reviewed changes
Comment thread lte/gateway/c/oai/include/state_manager.h
ulaskozat
ulaskozat reviewed Apr 1, 2021
View reviewed changes
Comment thread lte/gateway/c/oai/tasks/s1ap/s1ap_state_manager.h Outdated
@ulaskozat ulaskozat mentioned this pull request Apr 2, 2021
Merged
1 task
@ardzoht ardzoht force-pushed the reduce_redis_client_writes_ops branch from 08739c2 to 87fc437 Compare April 2, 2021 06:58
ulaskozat
ulaskozat approved these changes Apr 2, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@ulaskozat ulaskozat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ardzoht ardzoht force-pushed the reduce_redis_client_writes_ops branch from 87fc437 to ab0fa35 Compare April 2, 2021 21:26
@ardzoht ardzoht force-pushed the reduce_redis_client_writes_ops branch from ab0fa35 to e249d86 Compare April 2, 2021 21:43
@ardzoht ardzoht enabled auto-merge (squash) April 2, 2021 21:50
@ardzoht ardzoht merged commit 065c757 into magma:master Apr 2, 2021
chandra-77 pushed a commit to chandra-77/magma that referenced this pull request Apr 6, 2021
@ardzoht @chandra-77
[lte][agw] Add hash-based validation to reduce redis writes operation…
d6241d3 
…s on MME (magma#5868)

* Redis client write perf improvements

Signed-off-by: Alex Rodriguez <[email protected]>

* Removing state conversion for static PCC rules on SPGW

Signed-off-by: Alex Rodriguez <[email protected]>

* Adding hash based versioning check for redis writes

Signed-off-by: Alex Rodriguez <[email protected]>
@ardzoht ardzoht linked an issue Apr 28, 2021 that may be closed by this pull request
MME Redis - Write Optimization #5693
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ulaskozat ulaskozat ulaskozat approved these changes

@lionelgo lionelgo Awaiting requested review from lionelgo

@ssanadhya ssanadhya Awaiting requested review from ssanadhya

Assignees

No one assigned

Labels

component: agw Access gateway-related issue size/L Denotes a Pull Request that changes 100-499 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MME Redis - Write Optimization [lte][agw] Hash-based versioning and validation to reduce write operations on MME

3 participants

@ardzoht @ulaskozat @magmabot