[lte][agw] Scptd modifications to avoid burst after mme recovery#5355
Merged
ulaskozat merged 2 commits intomagma:masterfrom Mar 8, 2021
Merged
[lte][agw] Scptd modifications to avoid burst after mme recovery#5355ulaskozat merged 2 commits intomagma:masterfrom
ulaskozat merged 2 commits intomagma:masterfrom
Conversation
Signed-off-by: Ulas Kozat <[email protected]>
Contributor
Author
|
MAGMA-OAI-TESTS |
Signed-off-by: Ulas Kozat <[email protected]>
Contributor
|
MAGMA-OAI-TESTS |
Contributor
|
Build failure on our variant 7/14] Building CXX object CMakeFiles/SCTPD_LIB.dir/sctp_connection.cpp.o
FAILED: CMakeFiles/SCTPD_LIB.dir/sctp_connection.cpp.o
/usr/bin/c++ -DLOG_WITH_GLOG -I/usr/local/include/prometheus -I/magma/lte/gateway/c/sctpd -I. -I/magma/orc8r/gateway/c/common/logging -g -std=gnu++14 -MD -MT CMakeFiles/SCTPD_LIB.dir/sctp_connection.cpp.o -MF CMakeFiles/SCTPD_LIB.dir/sctp_connection.cpp.o.d -o CMakeFiles/SCTPD_LIB.dir/sctp_connection.cpp.o -c /magma/lte/gateway/c/sctpd/sctp_connection.cpp
/magma/lte/gateway/c/sctpd/sctp_connection.cpp: In member function 'magma::sctpd::SctpStatus magma::sctpd::SctpConnection::HandleComUp(int, sctp_assoc_change*)':
/magma/lte/gateway/c/sctpd/sctp_connection.cpp:271:54: error: no matching function for call to 'magma::sctpd::SctpEventHandler::HandleNewAssoc(sctp_assoc_t&, __u16&, __u16&, std::__cxx11::string&)'
change->sac_outbound_streams, ran_cp_ipaddr) < 0) {
^
In file included from /magma/lte/gateway/c/sctpd/sctp_connection.cpp:14:0:
/magma/lte/gateway/c/sctpd/sctp_connection.h:42:15: note: candidate: virtual int magma::sctpd::SctpEventHandler::HandleNewAssoc(uint32_t, uint32_t, uint32_t, uint32_t, std::__cxx11::string&)
virtual int HandleNewAssoc(
^~~~~~~~~~~~~~
/magma/lte/gateway/c/sctpd/sctp_connection.h:42:15: note: candidate expects 5 arguments, 4 provided |
rdefosse
requested changes
Mar 8, 2021
Contributor
rdefosse
left a comment
rdefosse
left a comment
There was a problem hiding this comment.
Build failure on our variant
rdefosse
approved these changes
Mar 8, 2021
ssanadhya
approved these changes
Mar 8, 2021
ulaskozat
added a commit
that referenced
this pull request
Mar 9, 2021
* Scptd modifications to avoid burst after mme recovery Signed-off-by: Ulas Kozat <[email protected]>
ssanadhya
pushed a commit
to ssanadhya/magma
that referenced
this pull request
Mar 10, 2021
…ma#5355) * Scptd modifications to avoid burst after mme recovery Signed-off-by: Ulas Kozat <[email protected]>
ssanadhya
pushed a commit
to ssanadhya/magma
that referenced
this pull request
Mar 10, 2021
…ma#5355) * Scptd modifications to avoid burst after mme recovery Signed-off-by: Ulas Kozat <[email protected]>
chandra-77
pushed a commit
to chandra-77/magma
that referenced
this pull request
Mar 30, 2021
…ma#5355) * Scptd modifications to avoid burst after mme recovery Signed-off-by: Ulas Kozat <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In stateless mode, when mme crashes, sctpd was queuing up duplicate events from the same UE towards MME due to UE timers. This PR makes the following improvements:
Test Plan
Spirent tests and S1 AP tests with forced MME restarts.
Additional Information