[MME][ZMQ] Protect against multiple threads using the same context#5307
Merged
ulaskozat merged 1 commit intomagma:masterfrom Mar 4, 2021
Merged
[MME][ZMQ] Protect against multiple threads using the same context#5307ulaskozat merged 1 commit intomagma:masterfrom
ulaskozat merged 1 commit intomagma:masterfrom
Conversation
Signed-off-by: Tariq Al-Khasib <[email protected]>
talkhasib
requested review from
ardzoht,
lionelgo,
ssanadhya and
ulaskozat
as code owners
Contributor
|
MAGMA-OAI-TESTS |
ulaskozat
added
apply-v1.3
Codecov Report
@@ Coverage Diff @@
## master #5307 +/- ##
=======================================
Coverage 63.60% 63.60%
=======================================
Files 301 301
Lines 20340 20340
=======================================
Hits 12937 12937
Misses 5494 5494
Partials 1909 1909 Continue to review full report at Codecov.
|
themarwhal
pushed a commit
that referenced
this pull request
Mar 4, 2021
…5307) Signed-off-by: Tariq Al-Khasib <[email protected]>
themarwhal
pushed a commit
that referenced
this pull request
Mar 4, 2021
…5307) Signed-off-by: Tariq Al-Khasib <[email protected]>
chandra-77
pushed a commit
to chandra-77/magma
that referenced
this pull request
Mar 30, 2021
…agma#5307) Signed-off-by: Tariq Al-Khasib <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tariq Al-Khasib [email protected]
Summary
Tasks interfacing to outside of MME create new threads when handling GRPC calls. Thus, zmq context is getting shared among multiple threads. This could create many race issues. The services in question are (SCTP, S6A, and SPGW) + Timers
This PR protects the zmq context with a mutex for exclusive access.
Test Plan
fab integ_test