[lte][agw]Mitigate GRPC timeouts in S6a requests#4698
Merged
ulaskozat merged 14 commits intomagma:masterfrom Feb 9, 2021
Merged
[lte][agw]Mitigate GRPC timeouts in S6a requests#4698ulaskozat merged 14 commits intomagma:masterfrom
ulaskozat merged 14 commits intomagma:masterfrom
Conversation
Signed-off-by: Ulas Kozat <[email protected]>
ulaskozat
added
component: agw
ulaskozat
requested review from
ardzoht,
emakeev,
hcgatewood,
mpgermano,
pshelar and
ssanadhya
as code owners
1 task
shaddi
reviewed
Feb 3, 2021
Contributor
shaddi
left a comment
shaddi
left a comment
There was a problem hiding this comment.
Like the direction you're going with this but suggest we do this in a loop rather than a one-shot retry until we fix the underlying issue.
talkhasib
reviewed
Feb 3, 2021
Contributor
|
MAGMA-OAI-TESTS |
Contributor
|
Running also on our pipeline |
Signed-off-by: Ulas Kozat <[email protected]>
Signed-off-by: Ulas Kozat <[email protected]>
Signed-off-by: Ulas Kozat <[email protected]>
|
This pull request introduces 2 alerts when merging 0e6825c into 601d6e6 - view on LGTM.com new alerts:
|
Signed-off-by: Ulas Kozat <[email protected]>
Signed-off-by: Ulas Kozat <[email protected]>
Signed-off-by: Ulas Kozat <[email protected]>
Contributor
|
MAGMA-OAI-TESTS |
talkhasib
reviewed
Feb 5, 2021
Comment on lines
+57
to
+59
| db_location_list.append(db_location[:i] + '0' + str(n_shard) + db_location[i:]) | ||
| else: | ||
| db_location_list.append(db_location[:i] + str(n_shard) + db_location[i:]) |
Contributor
There was a problem hiding this comment.
Maybe you can use "{:02d}".format(n_shard)
Contributor
Author
There was a problem hiding this comment.
actually I will eliminate this, it is a residual from earlier commits where I wasn't keeping a list...
talkhasib
reviewed
Feb 5, 2021
talkhasib
reviewed
Feb 5, 2021
talkhasib
reviewed
Feb 5, 2021
Signed-off-by: Ulas Kozat <[email protected]>
|
This pull request introduces 2 alerts when merging 361d160 into 1177eba - view on LGTM.com new alerts:
|
Signed-off-by: Ulas Kozat <[email protected]>
Signed-off-by: Ulas Kozat <[email protected]>
|
This pull request introduces 1 alert when merging b75ba72 into 1177eba - view on LGTM.com new alerts:
|
Contributor
|
MAGMA-OAI-TESTS |
ssanadhya
reviewed
Feb 8, 2021
ssanadhya
approved these changes
Feb 8, 2021
Contributor
ssanadhya
left a comment
ssanadhya
left a comment
There was a problem hiding this comment.
Changes in S6aClient.h look good to me!
mpgermano
approved these changes
Feb 8, 2021
ardzoht
approved these changes
Feb 8, 2021
Contributor
ardzoht
left a comment
ardzoht
left a comment
There was a problem hiding this comment.
minor nits, overall LGTM
Signed-off-by: Ulas Kozat <[email protected]>
Signed-off-by: Ulas Kozat <[email protected]>
Signed-off-by: Ulas Kozat <[email protected]>
Signed-off-by: Ulas Kozat <[email protected]>
Contributor
|
MAGMA-OAI-TESTS |
themarwhal
pushed a commit
that referenced
this pull request
Feb 9, 2021
* Mitigate GRPC timeouts in S6a requests Signed-off-by: Ulas Kozat <[email protected]> * Sharding at file level and set workers to 10 in config Signed-off-by: Ulas Kozat <[email protected]> * Fix indexing Signed-off-by: Ulas Kozat <[email protected]> * resolve nit comment Signed-off-by: Ulas Kozat <[email protected]> * Keep connection lock between table deletion and update phases Signed-off-by: Ulas Kozat <[email protected]> * Remove unused libs Signed-off-by: Ulas Kozat <[email protected]> * Add defaultdict Signed-off-by: Ulas Kozat <[email protected]> * address review comments Signed-off-by: Ulas Kozat <[email protected]> * fix object field name, missing s Signed-off-by: Ulas Kozat <[email protected]> * removed dangling variable due to the changes in the prev commits Signed-off-by: Ulas Kozat <[email protected]> * Address review comments Signed-off-by: Ulas Kozat <[email protected]> * Fix unit tests Signed-off-by: Ulas Kozat <[email protected]> * Pylint fixes Signed-off-by: Ulas Kozat <[email protected]> * Change to temporary file lib Signed-off-by: Ulas Kozat <[email protected]>
chandra-77
pushed a commit
to chandra-77/magma
that referenced
this pull request
Mar 30, 2021
* Mitigate GRPC timeouts in S6a requests Signed-off-by: Ulas Kozat <[email protected]> * Sharding at file level and set workers to 10 in config Signed-off-by: Ulas Kozat <[email protected]> * Fix indexing Signed-off-by: Ulas Kozat <[email protected]> * resolve nit comment Signed-off-by: Ulas Kozat <[email protected]> * Keep connection lock between table deletion and update phases Signed-off-by: Ulas Kozat <[email protected]> * Remove unused libs Signed-off-by: Ulas Kozat <[email protected]> * Add defaultdict Signed-off-by: Ulas Kozat <[email protected]> * address review comments Signed-off-by: Ulas Kozat <[email protected]> * fix object field name, missing s Signed-off-by: Ulas Kozat <[email protected]> * removed dangling variable due to the changes in the prev commits Signed-off-by: Ulas Kozat <[email protected]> * Address review comments Signed-off-by: Ulas Kozat <[email protected]> * Fix unit tests Signed-off-by: Ulas Kozat <[email protected]> * Pylint fixes Signed-off-by: Ulas Kozat <[email protected]> * Change to temporary file lib Signed-off-by: Ulas Kozat <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
To mitigate GRPC timeouts during authentication step:
-- increased the RPC timeout from 3 seconds to 10 seconds. This is the hard time out.
-- implemented file level sharding of subscribers into 100 buckets based on their last 2 digits in IMSI
-- open/close connections per api call.
To allow number of workers configurable via service yml files, I removed the hardwired value for number of workers passed during service initialization.
Test Plan
Additional Information