Skip to content

fix(ci): Fix for library changes#15643

Merged
tapasmishra merged 2 commits intov1.9from
topic/panyogesh/fixci19contd
Mar 25, 2025
Merged

fix(ci): Fix for library changes#15643
tapasmishra merged 2 commits intov1.9from
topic/panyogesh/fixci19contd

Conversation

@panyogesh
Copy link
Copy Markdown
Contributor

Changes:

  • Changes for libsystemd

Summary

Test Plan

Additional Information

  • This change is backwards-breaking

Security Considerations

Changes:
  - Changes for libsystemd

Signed-off-by: shashidhar-patil <[email protected]>
@panyogesh panyogesh requested a review from a team as a code owner March 25, 2025 04:57
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label Mar 25, 2025
@github-actions github-actions bot added component: cwf component: feg FEG-gateway related issues labels Mar 25, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

COPY keys/linux_foundation_registry_key.asc /etc/apt/trusted.gpg.d/magma.asc
RUN add-apt-repository "deb https://linuxfoundation.jfrog.io/artifactory/magma-packages-test focal-1.9.0 main"

RUN apt-get update && \
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [hadolint] <DL3015> reported by reviewdog 🐶
Avoid additional packages by specifying --no-install-recommends

COPY keys/linux_foundation_registry_key.asc /etc/apt/trusted.gpg.d/magma.asc
RUN add-apt-repository "deb https://linuxfoundation.jfrog.io/artifactory/magma-packages-test focal-1.9.0 main"

RUN apt-get update && \
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [hadolint] <DL3009> reported by reviewdog 🐶
Delete the apt-get lists after installing something

# workaround to avoid interactive tzdata configurtaion
ARG DEBIAN_FRONTEND=noninteractive

RUN apt-get update && \
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [hadolint] <DL3015> reported by reviewdog 🐶
Avoid additional packages by specifying --no-install-recommends

RUN add-apt-repository "deb https://linuxfoundation.jfrog.io/artifactory/magma-packages-test focal-1.9.0 main" && \
add-apt-repository "deb http://archive.ubuntu.com/ubuntu/ focal-proposed restricted main multiverse universe"

RUN apt-get update && \
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [hadolint] <DL3009> reported by reviewdog 🐶
Delete the apt-get lists after installing something

RUN add-apt-repository "deb https://linuxfoundation.jfrog.io/artifactory/magma-packages-test focal-1.9.0 main" && \
add-apt-repository "deb http://archive.ubuntu.com/ubuntu/ focal-proposed restricted main multiverse universe"

RUN apt-get update && \
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [hadolint] <DL3015> reported by reviewdog 🐶
Avoid additional packages by specifying --no-install-recommends

COPY keys/linux_foundation_registry_key.asc /etc/apt/trusted.gpg.d/magma.asc
RUN add-apt-repository "deb https://linuxfoundation.jfrog.io/artifactory/magma-packages-test focal-1.9.0 main"

RUN apt-get update && \
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [hadolint] <DL3009> reported by reviewdog 🐶
Delete the apt-get lists after installing something

COPY keys/linux_foundation_registry_key.asc /etc/apt/trusted.gpg.d/magma.asc
RUN add-apt-repository "deb https://linuxfoundation.jfrog.io/artifactory/magma-packages-test focal-1.9.0 main"

RUN apt-get update && \
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [hadolint] <DL3015> reported by reviewdog 🐶
Avoid additional packages by specifying --no-install-recommends

# workaround to avoid interactive tzdata configuration
ARG DEBIAN_FRONTEND=noninteractive

RUN apt-get update && \
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [hadolint] <DL3015> reported by reviewdog 🐶
Avoid additional packages by specifying --no-install-recommends

RUN apt-key add /tmp/fluentbit.key && \
add-apt-repository "deb https://packages.fluentbit.io/ubuntu/focal focal main"

RUN apt-get update && \
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [hadolint] <DL3009> reported by reviewdog 🐶
Delete the apt-get lists after installing something

RUN apt-key add /tmp/fluentbit.key && \
add-apt-repository "deb https://packages.fluentbit.io/ubuntu/focal focal main"

RUN apt-get update && \
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [hadolint] <DL3015> reported by reviewdog 🐶
Avoid additional packages by specifying --no-install-recommends

@panyogesh panyogesh requested a review from a team as a code owner March 25, 2025 05:28
@panyogesh panyogesh requested a review from tmdzk March 25, 2025 05:28
Changes:
  - Adding the safe directory changes

Signed-off-by: shashidhar-patil <[email protected]>
@panyogesh panyogesh force-pushed the topic/panyogesh/fixci19contd branch from cf09db9 to a756ea6 Compare March 25, 2025 05:37
@tapasmishra tapasmishra merged commit 66e5268 into v1.9 Mar 25, 2025
70 of 72 checks passed
@tapasmishra tapasmishra deleted the topic/panyogesh/fixci19contd branch March 25, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: cwf component: feg FEG-gateway related issues size/M Denotes a PR that changes 30-99 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants