Thanks for opening a PR! 💯

A couple initial guidelines

• All commits must be signed off. This is enforced by PR DCO check.
• All PR titles must follow the semantic commits format. This is enforced by PR Check Title Or Commit Message.

Howto

• Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
• Checks. All required CI checks must pass before merge.
• Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

• Contributing Conventions for norms around contributed code

If this is your first Magma PR, also consider reading

• Developer Onboarding for onboarding as a new Magma developer
• Development Workflow for guidance on your first PR
• CI Checks for points of contact for failing or flaky CI checks
• Code Review Process for information on requesting reviews and contacting maintainers

DP Lint & Test

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 917309f.

♻️ This comment has been updated with latest results.

We need to figure out whether build [magmalte] failed: the custom script didn't produce an image with tag [magmalte:latest] from “Domain proxy integration tests with orc8r” is caused by this change or whether it occurs across the board.

On investigation:

• Other PRs are showing the same error
• I can't think of a logical reason for this PR to create this particular error.

I will approve this.

@nathaniel-bennett Thank you for making this happen. From start to finish it was a lot of work, but in the end it provided a really substantial safety improvement for all users.