Skip to content

fix(mme): Fixing the criticality of the HandoverCancelAcknowledge …#15337

Merged
panyogesh merged 1 commit intomasterfrom
sathya
Nov 9, 2023
Merged

fix(mme): Fixing the criticality of the HandoverCancelAcknowledge …#15337
panyogesh merged 1 commit intomasterfrom
sathya

Conversation

@Sathyaj27
Copy link
Copy Markdown
Contributor

@Sathyaj27 Sathyaj27 commented Nov 9, 2023

… PathSwitchRequestAcknowlidge

fix(mme): Fixing the criticality of the HandoverCancelAcknowledge and PathSwitchRequestAcknowlidge

Summary

#15198 #15197

Test Plan

Integration testing

Additional Information

  • This change is backwards-breaking

Security Considerations

@Sathyaj27
fix(mme): Fixing the criticality of the HandoverCancelAcknowledge and…
4e70930 
… PathSwitchRequestAcknowlidge

Signed-off-by: Sathyaj27 <[email protected]>
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Nov 9, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 9, 2023

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label Nov 9, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 9, 2023 •
edited
Loading

Bazel unit-test results

    1 files  ±    0    86 suites   - 146   3m 13s ⏱️ -13s
415 tests  - 314  415 ✔️  - 314  0 💤 ±0  0 ❌ ±0 
416 runs   - 314  416 ✔️  - 314  0 💤 ±0  0 ❌ ±0 

Results for commit 4e70930. ± Comparison against base commit 7909a89.

This pull request removes 314 tests. 
ChargingGrantTest ‑ test_get_action
ChargingGrantTest ‑ test_get_action_redirect
ChargingGrantTest ‑ test_get_action_restrict
ChargingGrantTest ‑ test_get_update_type
ChargingGrantTest ‑ test_marshal
ChargingGrantTest ‑ test_should_deactivate_service
ChargingGrantTest ‑ test_tolerance_quota_exhausted
EventHandlerTest ‑ test_event_handler_close_assoc
EventHandlerTest ‑ test_event_handler_new_assoc
EventHandlerTest ‑ test_event_handler_send_ul
…

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 9, 2023 •
edited
Loading

Bazel unit-test results --config=production

    1 files  ±    0    86 suites   - 43   3m 9s ⏱️ -17s
415 tests  - 193  415 ✔️  - 193  0 💤 ±0  0 ❌ ±0 
416 runs   - 193  416 ✔️  - 193  0 💤 ±0  0 ❌ ±0 

Results for commit 4e70930. ± Comparison against base commit 7909a89.

This pull request removes 193 tests. 
ChargingGrantTest ‑ test_get_action
ChargingGrantTest ‑ test_get_action_redirect
ChargingGrantTest ‑ test_get_action_restrict
ChargingGrantTest ‑ test_get_update_type
ChargingGrantTest ‑ test_marshal
ChargingGrantTest ‑ test_should_deactivate_service
ChargingGrantTest ‑ test_tolerance_quota_exhausted
EventHandlerTest ‑ test_event_handler_close_assoc
EventHandlerTest ‑ test_event_handler_new_assoc
EventHandlerTest ‑ test_event_handler_send_ul
…

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 9, 2023 •
edited
Loading

Bazel unit-test results --config=asan

    1 files  ±    0    86 suites   - 43   3m 7s ⏱️ -15s
415 tests  - 193  415 ✔️  - 193  0 💤 ±0  0 ❌ ±0 
416 runs   - 193  416 ✔️  - 193  0 💤 ±0  0 ❌ ±0 

Results for commit 4e70930. ± Comparison against base commit 7909a89.

This pull request removes 193 tests. 
ChargingGrantTest ‑ test_get_action
ChargingGrantTest ‑ test_get_action_redirect
ChargingGrantTest ‑ test_get_action_restrict
ChargingGrantTest ‑ test_get_update_type
ChargingGrantTest ‑ test_marshal
ChargingGrantTest ‑ test_should_deactivate_service
ChargingGrantTest ‑ test_tolerance_quota_exhausted
EventHandlerTest ‑ test_event_handler_close_assoc
EventHandlerTest ‑ test_event_handler_new_assoc
EventHandlerTest ‑ test_event_handler_send_ul
…

♻️ This comment has been updated with latest results.

@Sathyaj27 Sathyaj27 marked this pull request as ready for review November 9, 2023 07:28
@Sathyaj27 Sathyaj27 requested a review from a team as a code owner November 9, 2023 07:28
panyogesh
panyogesh approved these changes Nov 9, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@panyogesh panyogesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@panyogesh panyogesh merged commit 2bd75a2 into master Nov 9, 2023
@panyogesh panyogesh deleted the sathya branch November 9, 2023 11:30
This was referenced Nov 9, 2023
Closed
Closed
lucasgonze pushed a commit to lucasgonze/magma that referenced this pull request Feb 29, 2024
@Sathyaj27 @lucasgonze
fix(mme): Fixing the criticality of the HandoverCancelAcknowledge and…
ad60ee1 
… PathSwitchRequestAcknowlidge (magma#15337)

Signed-off-by: Sathyaj27 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panyogesh panyogesh panyogesh approved these changes

@prabinakpattnaik prabinakpattnaik Awaiting requested review from prabinakpattnaik prabinakpattnaik is a code owner automatically assigned from magma/approvers-gw

Assignees

No one assigned

Labels

component: agw Access gateway-related issue size/XS Denotes a PR that changes 0-9 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Sathyaj27 @panyogesh