Skip to content

fix(ci): Fixes for liblsan0 packages#15335

Merged
tapasmishra merged 1 commit intomagma:masterfrom
akhilamoyila9:topic/akhilamoyila9/fixci
Nov 6, 2023
Merged

fix(ci): Fixes for liblsan0 packages#15335
tapasmishra merged 1 commit intomagma:masterfrom
akhilamoyila9:topic/akhilamoyila9/fixci

Conversation

@akhilamoyila9
Copy link
Copy Markdown
Contributor

changes:

  1. Modified the PUSH_TO_REGISTRY condition for bazel_base and devcontainer
  2. Added workflow dispatch for bazel_cache_asan,bazel_cache_plain and bazel_cache_prod

Summary

LTE integration tests are failing

1.The Magma Vagrant images used for LTE integration tests contain the latest version of GCC along with the liblsan0 package.
2.However, the container image used to build the Magma Debian package contains an older version of GCC along with the liblsan0 package.
3.This inconsistency is causing the MME service of Magma to crash during the integration test

Test Plan

Additional Information

  • This change is backwards-breaking

Security Considerations

changes:
 1) Modified the PUSH_TO_REGISTRY condition for bazel_base and devcontainer
 2) Added workflow dispatch for bazel_cache_asan,bazel_cache_plain and bazel_cache_prod

Signed-off-by: akhilamoyila9 <[email protected]>
@akhilamoyila9 akhilamoyila9 requested a review from a team as a code owner November 6, 2023 10:17
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines. label Nov 6, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 6, 2023

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Nov 6, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 6, 2023

DP Lint & Test

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 9991614.

Copy link
Copy Markdown

@tapasmishra tapasmishra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tapasmishra tapasmishra merged commit dd43cff into magma:master Nov 6, 2023
lucasgonze pushed a commit to lucasgonze/magma that referenced this pull request Feb 29, 2024
changes:
 1) Modified the PUSH_TO_REGISTRY condition for bazel_base and devcontainer
 2) Added workflow dispatch for bazel_cache_asan,bazel_cache_plain and bazel_cache_prod

Signed-off-by: akhilamoyila9 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/S Denotes a PR that changes 10-29 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants