Skip to content

fix(ci): Fixes for liblsan0 packages#15334

Merged
tapasmishra merged 1 commit intomagma:masterfrom
mohinali66:topic/mohinali66/cifix
Nov 3, 2023
Merged

fix(ci): Fixes for liblsan0 packages#15334
tapasmishra merged 1 commit intomagma:masterfrom
mohinali66:topic/mohinali66/cifix

Conversation

@mohinali66
Copy link
Copy Markdown
Contributor

@mohinali66 mohinali66 commented Oct 31, 2023 •
edited
Loading

changes:
- modified the .bazelrc file
- removed flags in the production build

Summary

Modified the .bazelrc to remove the sanitizer flag

Issue Analysis

  1. Leak Sanitizer Check is failing in the lsan lib init itself.
  2. It is a gcc/sanitizer bug
  3. It is here to stay in gcc10 which is now end-of-support. This is a bug in liblsan version 10.5.0(This is the official supported version in ubuntu20.04,gcc10).

fixes

  1. Disable the Leak Sanitizer entirely from the Production build. (Preferred as it unblocks v1.9 PRs)
  2. Removing the --config=lsan --copt=O3 from profuction build fixes the issue.

Test Plan

- Build workflow jobs

Additional Information

  • This change is backwards-breaking

Security Considerations

@mohinali
fix(ci): Fixes for liblsan0 packages
684e364 
changes:
 1) modified the .bazelrc file
 2) removed flags in the production build

Signed-off-by: mohinali <[email protected]>
@mohinali66 mohinali66 requested a review from a team as a code owner October 31, 2023 11:33
@mohinali66 mohinali66 requested a review from tmdzk October 31, 2023 11:33
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Oct 31, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 31, 2023

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 31, 2023

DP Lint & Test

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 684e364.

@panyogesh panyogesh mentioned this pull request Oct 31, 2023
Closed
panyogesh
panyogesh approved these changes Nov 2, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@panyogesh panyogesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tapasmishra
tapasmishra approved these changes Nov 3, 2023
View reviewed changes
Copy link
Copy Markdown

@tapasmishra tapasmishra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tapasmishra tapasmishra merged commit 70af37d into magma:master Nov 3, 2023
lucasgonze pushed a commit to lucasgonze/magma that referenced this pull request Feb 29, 2024
@mohinali66 @mohinali @lucasgonze
fix(ci): Fixes for liblsan0 packages (magma#15334)
ca1c9c7 
changes:
 1) modified the .bazelrc file
 2) removed flags in the production build

Signed-off-by: mohinali <[email protected]>
Co-authored-by: mohinali <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tapasmishra tapasmishra tapasmishra approved these changes

@panyogesh panyogesh panyogesh approved these changes

@tmdzk tmdzk Awaiting requested review from tmdzk tmdzk is a code owner automatically assigned from magma/approvers-infra

Assignees

No one assigned

Labels

size/XS Denotes a PR that changes 0-9 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mohinali66 @tapasmishra @panyogesh @mohinali