Skip to content

fix(amf): Added Service Accept handling in case of Service Request with uplink data status#15330

Merged
panyogesh merged 2 commits intomasterfrom
service_accept_handling
Nov 9, 2023
Merged

fix(amf): Added Service Accept handling in case of Service Request with uplink data status#15330
panyogesh merged 2 commits intomasterfrom
service_accept_handling

Conversation

@Akshayp77
Copy link
Copy Markdown
Contributor

@Akshayp77 Akshayp77 commented Oct 26, 2023

Summary

Added Service Accept code In case If the Uplink data status IE is included in the Service Request message.

Test Plan

Tested with Ue-Ran-Sim.
Steps followed:
-Bring up 5g call flow.
-Restart Gnb.

Additional Information

As per the 3gpp spec 24.501
If the Uplink data status IE is included in the SERVICE REQUEST message and the UE is: a) not in NB-N1 mode; or b) in NB-N1 mode and the UE does not indicate a request to have user-plane resources established for a number of PDU sessions that exceeds the UE's maximum number of supported user-plane resources; the AMF shall: a) indicate the SMF to re-establish the user-plane resources for the corresponding PDU sessions; b) include the PDU session reactivation result IE in the SERVICE ACCEPT message to indicate the user-plane resources re-establishment result of the PDU sessions for which the UE requested to re-establish the user-plane resources; and c) determine the UE presence in LADN service area and forward the UE presence in LADN service area towards the SMF, if the corresponding PDU session is a PDU session for LADN.

Packet2610.zip

Security Considerations

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines. label Oct 26, 2023
@github-actions
Copy link
Copy Markdown
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label Oct 26, 2023
@Akshayp77 Akshayp77 self-assigned this Oct 26, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 26, 2023

Bazel unit-test results

    1 files  ±    0    86 suites   - 146   3m 13s ⏱️ -45s
415 tests  - 314  415 ✔️  - 314  0 💤 ±0  0 ±0 
416 runs   - 314  416 ✔️  - 314  0 💤 ±0  0 ±0 

Results for commit 51fd05e. ± Comparison against base commit dd43cff.

This pull request removes 314 tests.
ChargingGrantTest ‑ test_get_action
ChargingGrantTest ‑ test_get_action_redirect
ChargingGrantTest ‑ test_get_action_restrict
ChargingGrantTest ‑ test_get_update_type
ChargingGrantTest ‑ test_marshal
ChargingGrantTest ‑ test_should_deactivate_service
ChargingGrantTest ‑ test_tolerance_quota_exhausted
EventHandlerTest ‑ test_event_handler_close_assoc
EventHandlerTest ‑ test_event_handler_new_assoc
EventHandlerTest ‑ test_event_handler_send_ul
…

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 26, 2023

Bazel unit-test results --config=production

    1 files  ±    0    86 suites   - 43   3m 9s ⏱️ -3s
415 tests  - 193  415 ✔️  - 193  0 💤 ±0  0 ±0 
416 runs   - 193  416 ✔️  - 193  0 💤 ±0  0 ±0 

Results for commit 51fd05e. ± Comparison against base commit dd43cff.

This pull request removes 193 tests.
ChargingGrantTest ‑ test_get_action
ChargingGrantTest ‑ test_get_action_redirect
ChargingGrantTest ‑ test_get_action_restrict
ChargingGrantTest ‑ test_get_update_type
ChargingGrantTest ‑ test_marshal
ChargingGrantTest ‑ test_should_deactivate_service
ChargingGrantTest ‑ test_tolerance_quota_exhausted
EventHandlerTest ‑ test_event_handler_close_assoc
EventHandlerTest ‑ test_event_handler_new_assoc
EventHandlerTest ‑ test_event_handler_send_ul
…

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 26, 2023

Bazel unit-test results --config=asan

    1 files  ±    0    86 suites   - 43   3m 7s ⏱️ -27s
415 tests  - 193  415 ✔️  - 193  0 💤 ±0  0 ±0 
416 runs   - 193  416 ✔️  - 193  0 💤 ±0  0 ±0 

Results for commit 51fd05e. ± Comparison against base commit dd43cff.

This pull request removes 193 tests.
ChargingGrantTest ‑ test_get_action
ChargingGrantTest ‑ test_get_action_redirect
ChargingGrantTest ‑ test_get_action_restrict
ChargingGrantTest ‑ test_get_update_type
ChargingGrantTest ‑ test_marshal
ChargingGrantTest ‑ test_should_deactivate_service
ChargingGrantTest ‑ test_tolerance_quota_exhausted
EventHandlerTest ‑ test_event_handler_close_assoc
EventHandlerTest ‑ test_event_handler_new_assoc
EventHandlerTest ‑ test_event_handler_send_ul
…

♻️ This comment has been updated with latest results.

Copy link
Copy Markdown
Contributor

@Sathyaj27 Sathyaj27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Akshayp77 Akshayp77 force-pushed the service_accept_handling branch from 6361f2e to 0f6b6c0 Compare October 27, 2023 06:43
Comment thread lte/gateway/c/core/oai/tasks/amf/amf_app_handler.cpp Outdated
Comment thread lte/gateway/c/core/oai/tasks/amf/amf_app_handler.cpp Outdated
@Akshayp77 Akshayp77 force-pushed the service_accept_handling branch from 0f6b6c0 to 9c616bf Compare October 27, 2023 08:57
Comment thread lte/gateway/c/core/oai/tasks/amf/amf_app_handler.cpp Outdated
Comment thread lte/gateway/c/core/oai/tasks/amf/amf_app_handler.cpp Outdated
@Akshayp77 Akshayp77 force-pushed the service_accept_handling branch from 9c616bf to 4d315eb Compare October 27, 2023 09:12
@panyogesh panyogesh marked this pull request as ready for review November 6, 2023 05:55
@panyogesh panyogesh requested a review from a team as a code owner November 6, 2023 05:55
@panyogesh panyogesh requested a review from pshelar November 6, 2023 05:55
@Akshayp77 Akshayp77 force-pushed the service_accept_handling branch from f5f2343 to 11a58da Compare November 6, 2023 06:50
Copy link
Copy Markdown
Contributor

@panyogesh panyogesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@panyogesh panyogesh merged commit 7909a89 into master Nov 9, 2023
@panyogesh panyogesh deleted the service_accept_handling branch November 9, 2023 06:36
lucasgonze pushed a commit to lucasgonze/magma that referenced this pull request Feb 29, 2024
…th uplink data status (magma#15330)

Signed-off-by: Akshayp77 <[email protected]>
Co-authored-by: panyogesh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: agw Access gateway-related issue size/S Denotes a PR that changes 10-29 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants