Skip to content

fix(mme): Handling missing support for MME_UE_S1AP_ID and eNB_UE_S1AP_ID in E-RAB Modification Indication#15326

Merged
panyogesh merged 3 commits intomasterfrom
topic/vamsi/sec-issue-6-7
Nov 22, 2023
Merged

fix(mme): Handling missing support for MME_UE_S1AP_ID and eNB_UE_S1AP_ID in E-RAB Modification Indication#15326
panyogesh merged 3 commits intomasterfrom
topic/vamsi/sec-issue-6-7

Conversation

@Krishnavamsi-wavelabs
Copy link
Copy Markdown
Contributor

@Krishnavamsi-wavelabs Krishnavamsi-wavelabs commented Oct 20, 2023

Summary

Handling missing support for MME_UE_S1AP_ID and eNB_UE_S1AP_ID in E-RAB Modification Indication

Test Plan

Added Unit test for Handling missing support for MME_UE_S1AP_ID and eNB_UE_S1AP_ID

@Krishnavamsi-wavelabs
fix(mme): Handling missing support for MME_UE_S1AP_ID and eNB_UE_S1AP…
b08dff2 
…_ID in E-RAB Modification Indication

Signed-off-by: krishnavamsi-wavelabs <[email protected]>
@Krishnavamsi-wavelabs Krishnavamsi-wavelabs requested a review from a team as a code owner October 20, 2023 13:16
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label Oct 20, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 20, 2023

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label Oct 20, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 20, 2023 •
edited
Loading

Bazel unit-test results --config=production

    1 files  ±    0    86 suites   - 43   3m 13s ⏱️ -7s
417 tests  - 191  417 ✔️  - 191  0 💤 ±0  0 ❌ ±0 
418 runs   - 191  418 ✔️  - 191  0 💤 ±0  0 ❌ ±0 

Results for commit d30798d. ± Comparison against base commit 310acf9.

This pull request removes 193 and adds 2 tests. Note that renamed tests count towards both. 
ChargingGrantTest ‑ test_get_action
ChargingGrantTest ‑ test_get_action_redirect
ChargingGrantTest ‑ test_get_action_restrict
ChargingGrantTest ‑ test_get_update_type
ChargingGrantTest ‑ test_marshal
ChargingGrantTest ‑ test_should_deactivate_service
ChargingGrantTest ‑ test_tolerance_quota_exhausted
EventHandlerTest ‑ test_event_handler_close_assoc
EventHandlerTest ‑ test_event_handler_new_assoc
EventHandlerTest ‑ test_event_handler_send_ul
…

S1apMmeHandlersTest ‑ MalformedErabModificationENB_UE_S1AP_ID
S1apMmeHandlersTest ‑ MalformedErabModificationMME_UE_S1AP_ID

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 20, 2023 •
edited
Loading

Bazel unit-test results

    1 files  ±    0    86 suites   - 146   3m 13s ⏱️ -31s
417 tests  - 312  417 ✔️  - 312  0 💤 ±0  0 ❌ ±0 
418 runs   - 312  418 ✔️  - 312  0 💤 ±0  0 ❌ ±0 

Results for commit d30798d. ± Comparison against base commit 310acf9.

This pull request removes 314 and adds 2 tests. Note that renamed tests count towards both. 
ChargingGrantTest ‑ test_get_action
ChargingGrantTest ‑ test_get_action_redirect
ChargingGrantTest ‑ test_get_action_restrict
ChargingGrantTest ‑ test_get_update_type
ChargingGrantTest ‑ test_marshal
ChargingGrantTest ‑ test_should_deactivate_service
ChargingGrantTest ‑ test_tolerance_quota_exhausted
EventHandlerTest ‑ test_event_handler_close_assoc
EventHandlerTest ‑ test_event_handler_new_assoc
EventHandlerTest ‑ test_event_handler_send_ul
…

S1apMmeHandlersTest ‑ MalformedErabModificationENB_UE_S1AP_ID
S1apMmeHandlersTest ‑ MalformedErabModificationMME_UE_S1AP_ID

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 20, 2023 •
edited
Loading

Bazel unit-test results --config=asan

    1 files  ±    0    86 suites   - 43   3m 15s ⏱️ -2s
417 tests  - 191  417 ✔️  - 191  0 💤 ±0  0 ❌ ±0 
418 runs   - 191  418 ✔️  - 191  0 💤 ±0  0 ❌ ±0 

Results for commit d30798d. ± Comparison against base commit 310acf9.

This pull request removes 193 and adds 2 tests. Note that renamed tests count towards both. 
ChargingGrantTest ‑ test_get_action
ChargingGrantTest ‑ test_get_action_redirect
ChargingGrantTest ‑ test_get_action_restrict
ChargingGrantTest ‑ test_get_update_type
ChargingGrantTest ‑ test_marshal
ChargingGrantTest ‑ test_should_deactivate_service
ChargingGrantTest ‑ test_tolerance_quota_exhausted
EventHandlerTest ‑ test_event_handler_close_assoc
EventHandlerTest ‑ test_event_handler_new_assoc
EventHandlerTest ‑ test_event_handler_send_ul
…

S1apMmeHandlersTest ‑ MalformedErabModificationENB_UE_S1AP_ID
S1apMmeHandlersTest ‑ MalformedErabModificationMME_UE_S1AP_ID

♻️ This comment has been updated with latest results.

panyogesh
panyogesh approved these changes Nov 22, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@panyogesh panyogesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@panyogesh panyogesh enabled auto-merge (squash) November 22, 2023 22:25
@panyogesh panyogesh merged commit 7e26dbb into master Nov 22, 2023
@panyogesh panyogesh deleted the topic/vamsi/sec-issue-6-7 branch November 22, 2023 22:42
panyogesh added a commit that referenced this pull request Dec 4, 2023
@panyogesh
Revert "fix(mme): Handling missing support for MME_UE_S1AP_ID and eNB…
c98d758 
…_UE_S1AP_ID in E-RAB Modification Indication (#15326)"

This reverts commit 7e26dbb.
@panyogesh panyogesh mentioned this pull request Dec 4, 2023
Merged
panyogesh added a commit that referenced this pull request Dec 9, 2023
@panyogesh
Revert "fix(mme): Handling missing support for MME_UE_S1AP_ID and eNB…
a328c09 
…_UE_S1AP_ID in E-RAB Modification Indication (#15326)" (#15349)

This reverts commit 7e26dbb.
lucasgonze pushed a commit to lucasgonze/magma that referenced this pull request Feb 29, 2024
@Krishnavamsi-wavelabs @panyogesh @lucasgonze
fix(mme): Handling missing support for MME_UE_S1AP_ID and eNB_UE_S1AP…
2dcb15e 
…_ID in E-RAB Modification Indication (magma#15326)

Signed-off-by: krishnavamsi-wavelabs <[email protected]>
Co-authored-by: panyogesh <[email protected]>
lucasgonze pushed a commit to lucasgonze/magma that referenced this pull request Feb 29, 2024
@panyogesh @lucasgonze
Revert "fix(mme): Handling missing support for MME_UE_S1AP_ID and eNB…
30ad05d 
…_UE_S1AP_ID in E-RAB Modification Indication (magma#15326)" (magma#15349)

This reverts commit 7e26dbb.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panyogesh panyogesh panyogesh approved these changes

@GANESH-WAVELABS GANESH-WAVELABS Awaiting requested review from GANESH-WAVELABS GANESH-WAVELABS is a code owner automatically assigned from magma/approvers-gw

Assignees

No one assigned

Labels

component: agw Access gateway-related issue size/M Denotes a PR that changes 30-99 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Krishnavamsi-wavelabs @panyogesh