fix(orc8r): Stop web-inject attack on N/W creation#15321
Merged
Conversation
Contributor
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
Contributor
|
✔️ The Semantic PR check ended with status success. See instructions on formatting your commit and pull request titles. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| if (!allowedNetworkTypes.includes(data.networkType)) { | ||
| res | ||
| .status(400) | ||
| .send(`please provide a valid network type like: LTE, FEG_LTE, CWF or FEG`) |
Contributor
There was a problem hiding this comment.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace please·provide·a·valid·network·type·like:·LTE,·FEG_LTE,·CWF·or·FEG with ⏎············please·provide·a·valid·network·type·like:·LTE,·FEG_LTE,·CWF·or·FEG,⏎··········
Suggested change
| .send(`please provide a valid network type like: LTE, FEG_LTE, CWF or FEG`) | |
| .send( | |
| `please provide a valid network type like: LTE, FEG_LTE, CWF or FEG`, | |
| ) |
moinuddin1980
changed the title
moinuddin1980
force-pushed
the
topic/sec-issues/allow-net-type
branch
from
b8d657e to
44d6d31
Compare
pull-request-size
bot
added
size/S
Signed-off-by: jahid-wavelabs <[email protected]>
Signed-off-by: jahid-wavelabs <[email protected]>
Signed-off-by: jahid-wavelabs <[email protected]>
moinuddin1980
force-pushed
the
topic/sec-issues/allow-net-type
branch
from
94bca1e to
a1059e3
Compare
maxhbr
approved these changes
Nov 6, 2023
Member
maxhbr
left a comment
maxhbr
left a comment
There was a problem hiding this comment.
after a brief look at the code: seems to be sane and OK.
I did not test or verify the code.
lucasgonze
pushed a commit
to lucasgonze/magma
that referenced
this pull request
Feb 29, 2024
* Whitelist Net type to prevent web inject attack Signed-off-by: jahid-wavelabs <[email protected]> * Whitelist N/W type to prevent web inject attack Signed-off-by: jahid-wavelabs <[email protected]> * Whitelist N/W type to prevent web inject attack Signed-off-by: jahid-wavelabs <[email protected]> --------- Signed-off-by: jahid-wavelabs <[email protected]> Co-authored-by: jahid-wavelabs <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(orc8r): Stop web-inject attack on N/W creation
Summary
LTE, FEG_LTE, CWF, FEG,Test Plan
Tested manually by sending some web-inject script it filters the input and gives error