fix(ci): Fixes for liblsan0 packages in Bazell base image by akhilamoyila9 · Pull Request #15315 · magma/magma

akhilamoyila9 · 2023-10-04T10:19:32Z

fix(ci): Fixes for liblsan0 packages in Bazel base image

Summary

LTE integration tests are failing

The Magma Vagrant images used for LTE integration tests contain the latest version of GCC along with the liblsan0 package.
However, the container image used to build the Magma Debian package contains an older version of GCC along with the liblsan0 package.
This inconsistency is causing the MME service of Magma to crash during the integration test

Test Plan

To resolve this issue, we need to upgrade the GCC and liblsan0 package on the base container image used to build the Debian package.
This upgrade will ensure compatibility between the test environment and the package building environment, preventing the MME service from crashing during tests.

Additional Information

This change is backwards-breaking

Security Considerations

Signed-off-by: akhilamoyila9 <[email protected]>

github-actions · 2023-10-04T10:19:50Z

Thanks for opening a PR! 💯

A couple initial guidelines

All commits must be signed off. This is enforced by PR DCO check.
All PR titles must follow the semantic commits format. This is enforced by PR Check Title Or Commit Message.

Howto

Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
Checks. All required CI checks must pass before merge.
Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

Contributing Conventions for norms around contributed code

If this is your first Magma PR, also consider reading

Developer Onboarding for onboarding as a new Magma developer
Development Workflow for guidance on your first PR
CI Checks for points of contact for failing or flaky CI checks
Code Review Process for information on requesting reviews and contacting maintainers

github-actions · 2023-10-04T10:20:01Z

✔️ The Semantic PR check ended with status success. See instructions on formatting your commit and pull request titles.

github-actions · 2023-10-04T10:20:43Z

DP Lint & Test

0 tests 0 ✔️ 0s ⏱️
0 suites 0 💤
0 files 0 ❌

Results for commit 3bc3bf9.

♻️ This comment has been updated with latest results.

changes: 1) changed the push to registry condition to true Signed-off-by: akhilamoyila9 <[email protected]>

changes: 1) Added if block in build_dockerfile_bazel_base and build_dockerfile_devcontainer jobs 2) Chnaged the PUSH_TO_REGISTRY condition to true Signed-off-by: akhilamoyila9 <[email protected]>

tapasmishra · 2023-10-09T09:46:15Z

LGTM!

tapasmishra

LGTM!

mohinali

lgtm

panyogesh

LGTM

mohinali66

LGTM

maxhbr

This PR lacks a description
some commits just have the description fix(ci)
as this moves the guard to an earlier place in the pipeline, it stops the container to be built on PRs and in forks and therefore reduces test coverage

tapasmishra · 2023-10-10T03:27:12Z

This PR lacks a description

some commits just have the description fix(ci)

as this moves the guard to an earlier place in the pipeline, it stops the container to be built on PRs and in forks and therefore reduces test coverage

@maxhbr - I have asked to the engineer to update the description. Intentionally we have moved the guard to the earlier place to skip execution during the PR. It will fail pushing the image during the PR hence we can't merge the PR in the normal way. As this is a temporary arrangement and will be reverted back as soon as after the bazel-base image update I don't see any risk. Let me know your thoughts.

tapasmishra · 2023-10-10T03:29:10Z

This PR lacks a description

some commits just have the description fix(ci)

as this moves the guard to an earlier place in the pipeline, it stops the container to be built on PRs and in forks and therefore reduces test coverage

@maxhbr - I have asked to the engineer to update the description. Intentionally we have moved the guard to the earlier place to skip execution during the PR. It will fail pushing the image during the PR hence we can't merge the PR in the normal way. As this is a temporary arrangement and will be reverted back as soon as after the bazel-base image update I don't see any risk. Let me know your thoughts.

LTE Integration tests are in red on the CI dashboard and this temporary arrangement will help fixing the LTE integration issue.

changes: 1.reverted the temporary changes in the Dockerfile Signed-off-by: akhilamoyila9 <[email protected]>

changes: 1. Modified the condition of githib.event_ name Signed-off-by: akhilamoyila9 <[email protected]>

changes: 1. Modified the condition of github.event_name Signed-off-by: akhilamoyila9 <[email protected]>

maxhbr

LGTM

Temporary fixes to update the bazel-base image.

fix(ci)

0de2fb3

Signed-off-by: akhilamoyila9 <[email protected]>

pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Oct 4, 2023

akhilamoyila9 changed the title ~~fix(ci)~~ fix(ci):added new line for testing Oct 4, 2023

fix(ci):changed the push to registry condition

e38d824

changes: 1) changed the push to registry condition to true Signed-off-by: akhilamoyila9 <[email protected]>

akhilamoyila9 force-pushed the topic/akhilamoyila9/testtprr branch from 6fc0a33 to e38d824 Compare October 4, 2023 11:00

akhilamoyila9 requested a review from a team as a code owner October 4, 2023 11:00

akhilamoyila9 requested a review from ssanadhya October 4, 2023 11:00

github-actions bot added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Oct 4, 2023

fix(ci): Changed condition for Devcontainer and bazel_base

48ec08e

changes: 1) Added if block in build_dockerfile_bazel_base and build_dockerfile_devcontainer jobs 2) Chnaged the PUSH_TO_REGISTRY condition to true Signed-off-by: akhilamoyila9 <[email protected]>

pull-request-size bot added size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Oct 9, 2023

tapasmishra changed the title ~~fix(ci):added new line for testing~~ fix(ci): Fixes for liblsan0 packages in Bazell base image Oct 9, 2023

tapasmishra self-requested a review October 9, 2023 09:45

tapasmishra approved these changes Oct 9, 2023

View reviewed changes

tapasmishra requested review from mohinali66 and panyogesh October 9, 2023 09:47

mohinali approved these changes Oct 9, 2023

View reviewed changes

panyogesh approved these changes Oct 9, 2023

View reviewed changes

mohinali66 approved these changes Oct 9, 2023

View reviewed changes

maxhbr requested changes Oct 9, 2023

View reviewed changes

Comment thread .devcontainer/bazel-base/Dockerfile Outdated

Comment thread .github/workflows/docker-builder-devcontainer.yml Outdated

fix(ci): Fixes for liblsan0 packages in Bazel base image(magma#15315)

9696c6e

changes: 1.reverted the temporary changes in the Dockerfile Signed-off-by: akhilamoyila9 <[email protected]>

akhilamoyila9 force-pushed the topic/akhilamoyila9/testtprr branch from ef8274e to 9696c6e Compare October 11, 2023 16:27

fix(ci): Fixes for liblsan0 packages in Bazel base image (magma#5315)

2dc106e

changes: 1. Modified the condition of githib.event_ name Signed-off-by: akhilamoyila9 <[email protected]>

akhilamoyila9 force-pushed the topic/akhilamoyila9/testtprr branch from 9acb9ec to 2dc106e Compare October 12, 2023 06:49

fix(ci): Fixes for liblsan0 packages in Bazel base image (magma#15315)

3551559

changes: 1. Modified the condition of github.event_name Signed-off-by: akhilamoyila9 <[email protected]>

akhilamoyila9 force-pushed the topic/akhilamoyila9/testtprr branch from 41a61ef to 2dc106e Compare October 12, 2023 06:56

Merge branch 'master' into topic/akhilamoyila9/testtprr

3bc3bf9

tapasmishra requested a review from maxhbr October 12, 2023 09:20

maxhbr approved these changes Oct 12, 2023

View reviewed changes

tapasmishra merged commit 0a7c8d4 into magma:master Oct 12, 2023

lucasgonze pushed a commit to lucasgonze/magma that referenced this pull request Feb 29, 2024

fix(ci): Fixes for liblsan0 packages in Bazel base image (magma#15315)

baae654

Temporary fixes to update the bazel-base image.

Conversation

akhilamoyila9 commented Oct 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test Plan

Additional Information

Security Considerations

Uh oh!

github-actions bot commented Oct 4, 2023

Howto

More info

Uh oh!

github-actions bot commented Oct 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

DP Lint & Test

Uh oh!

tapasmishra commented Oct 9, 2023

Uh oh!

tapasmishra left a comment

Choose a reason for hiding this comment

Uh oh!

mohinali left a comment

Choose a reason for hiding this comment

Uh oh!

panyogesh left a comment

Choose a reason for hiding this comment

Uh oh!

mohinali66 left a comment

Choose a reason for hiding this comment

Uh oh!

maxhbr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

tapasmishra commented Oct 10, 2023

Uh oh!

tapasmishra commented Oct 10, 2023

Uh oh!

maxhbr left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

akhilamoyila9 commented Oct 4, 2023 •

edited

Loading

github-actions bot commented Oct 4, 2023 •

edited

Loading

github-actions bot commented Oct 4, 2023 •

edited

Loading