Skip to content

fix(mme): Handling missing Supported TAs, ENB_UE_S1AP_ID and MME_UE_S1AP_ID#15309

Merged
panyogesh merged 1 commit intomasterfrom
topic/vamsi/sec-issues-14-15-16
Oct 4, 2023
Merged

fix(mme): Handling missing Supported TAs, ENB_UE_S1AP_ID and MME_UE_S1AP_ID#15309
panyogesh merged 1 commit intomasterfrom
topic/vamsi/sec-issues-14-15-16

Conversation

@Krishnavamsi-wavelabs
Copy link
Copy Markdown
Contributor

@Krishnavamsi-wavelabs Krishnavamsi-wavelabs commented Sep 25, 2023 •
edited
Loading

Summary

Handling missing Supported TAs, ENB_UE_S1AP_ID and MME_UE_S1AP_ID

Test Plan

Added test cases for missing Supported TAs, ENB_UE_S1AP_ID and MME_UE_S1AP_ID

Logs:

vagrant@magma-dev ~/magma (topic/vamsi/sec-issues-14)$ bazel test //lte/gateway/c/core/oai/test/s1ap_task:s1ap_mme_handlers_test
INFO: Invocation ID: 91a8c387-785d-4c3f-9563-9031675cffb6
...
Target //lte/gateway/c/core/oai/test/s1ap_task:s1ap_mme_handlers_test up-to-date:
  bazel-bin/lte/gateway/c/core/oai/test/s1ap_task/s1ap_mme_handlers_test
INFO: Elapsed time: 60.780s, Critical Path: 59.36s
INFO: 8 processes: 2 internal, 6 linux-sandbox.
INFO: Build completed successfully, 8 total actions
//lte/gateway/c/core/oai/test/s1ap_task:s1ap_mme_handlers_test           PASSED in 49.7s

INFO: Build completed successfully, 8 total actions

4G call flow Logs

4G_call_flow.txt

@Krishnavamsi-wavelabs Krishnavamsi-wavelabs requested a review from a team as a code owner September 25, 2023 10:01
@pull-request-size pull-request-size bot added the size/L Denotes a Pull Request that changes 100-499 lines. label Sep 25, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 25, 2023

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label Sep 25, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 25, 2023 •
edited
Loading

Bazel unit-test results --config=asan

    1 files  ±    0    86 suites   - 43   3m 22s ⏱️ -1s
415 tests  - 190  415 ✔️  - 190  0 💤 ±0  0 ❌ ±0 
416 runs   - 190  416 ✔️  - 190  0 💤 ±0  0 ❌ ±0 

Results for commit 7bec55a. ± Comparison against base commit 81e4e77.

This pull request removes 193 and adds 3 tests. Note that renamed tests count towards both. 
ChargingGrantTest ‑ test_get_action
ChargingGrantTest ‑ test_get_action_redirect
ChargingGrantTest ‑ test_get_action_restrict
ChargingGrantTest ‑ test_get_update_type
ChargingGrantTest ‑ test_marshal
ChargingGrantTest ‑ test_should_deactivate_service
ChargingGrantTest ‑ test_tolerance_quota_exhausted
EventHandlerTest ‑ test_event_handler_close_assoc
EventHandlerTest ‑ test_event_handler_new_assoc
EventHandlerTest ‑ test_event_handler_send_ul
…

S1apMmeHandlersTest ‑ MalformedS1SetupRequiredSupportedTAs
S1apMmeHandlersTest ‑ MalformedUplinkNasTransportENB_UE_S1AP_ID
S1apMmeHandlersTest ‑ MalformedUplinkNasTransportMME_UE_S1AP_ID

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 25, 2023 •
edited
Loading

Bazel unit-test results

    1 files  ±    0    86 suites   - 146   3m 6s ⏱️ -20s
415 tests  - 311  415 ✔️  - 311  0 💤 ±0  0 ❌ ±0 
416 runs   - 311  416 ✔️  - 311  0 💤 ±0  0 ❌ ±0 

Results for commit 7bec55a. ± Comparison against base commit 81e4e77.

This pull request removes 314 and adds 3 tests. Note that renamed tests count towards both. 
ChargingGrantTest ‑ test_get_action
ChargingGrantTest ‑ test_get_action_redirect
ChargingGrantTest ‑ test_get_action_restrict
ChargingGrantTest ‑ test_get_update_type
ChargingGrantTest ‑ test_marshal
ChargingGrantTest ‑ test_should_deactivate_service
ChargingGrantTest ‑ test_tolerance_quota_exhausted
EventHandlerTest ‑ test_event_handler_close_assoc
EventHandlerTest ‑ test_event_handler_new_assoc
EventHandlerTest ‑ test_event_handler_send_ul
…

S1apMmeHandlersTest ‑ MalformedS1SetupRequiredSupportedTAs
S1apMmeHandlersTest ‑ MalformedUplinkNasTransportENB_UE_S1AP_ID
S1apMmeHandlersTest ‑ MalformedUplinkNasTransportMME_UE_S1AP_ID

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 25, 2023 •
edited
Loading

Bazel unit-test results --config=production

    1 files  ±    0    86 suites   - 43   3m 29s ⏱️ +4s
415 tests  - 190  415 ✔️  - 190  0 💤 ±0  0 ❌ ±0 
416 runs   - 190  416 ✔️  - 190  0 💤 ±0  0 ❌ ±0 

Results for commit 7bec55a. ± Comparison against base commit 81e4e77.

This pull request removes 193 and adds 3 tests. Note that renamed tests count towards both. 
ChargingGrantTest ‑ test_get_action
ChargingGrantTest ‑ test_get_action_redirect
ChargingGrantTest ‑ test_get_action_restrict
ChargingGrantTest ‑ test_get_update_type
ChargingGrantTest ‑ test_marshal
ChargingGrantTest ‑ test_should_deactivate_service
ChargingGrantTest ‑ test_tolerance_quota_exhausted
EventHandlerTest ‑ test_event_handler_close_assoc
EventHandlerTest ‑ test_event_handler_new_assoc
EventHandlerTest ‑ test_event_handler_send_ul
…

S1apMmeHandlersTest ‑ MalformedS1SetupRequiredSupportedTAs
S1apMmeHandlersTest ‑ MalformedUplinkNasTransportENB_UE_S1AP_ID
S1apMmeHandlersTest ‑ MalformedUplinkNasTransportMME_UE_S1AP_ID

♻️ This comment has been updated with latest results.

@Krishnavamsi-wavelabs Krishnavamsi-wavelabs self-assigned this Sep 27, 2023
@Krishnavamsi-wavelabs Krishnavamsi-wavelabs force-pushed the topic/vamsi/sec-issues-14-15-16 branch from 21afd07 to 7bec55a Compare September 29, 2023 05:45
panyogesh
panyogesh approved these changes Oct 4, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@panyogesh panyogesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@panyogesh panyogesh merged commit c50d10f into master Oct 4, 2023
@panyogesh panyogesh deleted the topic/vamsi/sec-issues-14-15-16 branch October 4, 2023 18:06
lucasgonze pushed a commit to lucasgonze/magma that referenced this pull request Feb 29, 2024
@Krishnavamsi-wavelabs @lucasgonze
fix(mme): Handling missing Supported TAs, ENB_UE_S1AP_ID and MME_UE_S…
79d3f68 
…1AP_ID (magma#15309)

Signed-off-by: krishnavamsi-wavelabs <[email protected]>
edaspb added a commit to edaspb/magma that referenced this pull request Mar 22, 2024
@edaspb
Handling missing Supported TAs, ENB_UE_S1AP_ID and MME_UE_S1AP_ID (ma…
b1e32a1 
…gma#15309)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panyogesh panyogesh panyogesh approved these changes

@rsarwad rsarwad Awaiting requested review from rsarwad rsarwad is a code owner automatically assigned from magma/approvers-gw

Assignees

@Krishnavamsi-wavelabs Krishnavamsi-wavelabs

Labels

component: agw Access gateway-related issue size/L Denotes a Pull Request that changes 100-499 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Krishnavamsi-wavelabs @panyogesh