Skip to content

fix(mme): Handling Missing RRC Establishment Cause IE and EUTRAN CGI field#15299

Merged
panyogesh merged 1 commit intomasterfrom
topic/vamsi/sec-issue-10
Sep 21, 2023
Merged

fix(mme): Handling Missing RRC Establishment Cause IE and EUTRAN CGI field#15299
panyogesh merged 1 commit intomasterfrom
topic/vamsi/sec-issue-10

Conversation

@Krishnavamsi-wavelabs
Copy link
Copy Markdown
Contributor

@Krishnavamsi-wavelabs Krishnavamsi-wavelabs commented Sep 4, 2023 •
edited
Loading

Summary

Handling Missing RRC Establishment Cause IE and EUTRAN CGI field.

Test Plan

Added test cases for Missing RRC Establishment Cause IE and EUTRAN CGI field.

Logs

vagrant@magma-dev ~/magma/lte/gateway (topic/vamsi/sec-issue-10)$ sudo bazel test //lte/gateway/c/core/oai/test/s1ap_task:s1ap_mme_handlers_test
...

Target //lte/gateway/c/core/oai/test/s1ap_task:s1ap_mme_handlers_test up-to-date:
  bazel-bin/lte/gateway/c/core/oai/test/s1ap_task/s1ap_mme_handlers_test
INFO: Elapsed time: 54.761s, Critical Path: 53.40s
INFO: 7 processes: 2 internal, 5 linux-sandbox.
INFO: Build completed successfully, 7 total actions
//lte/gateway/c/core/oai/test/s1ap_task:s1ap_mme_handlers_test           PASSED in 43.6s

INFO: Build completed successfully, 7 total actions

4G Call flow test Cases Logs

UT test case of PR 15299.docx

@Krishnavamsi-wavelabs Krishnavamsi-wavelabs requested a review from a team as a code owner September 4, 2023 08:28
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label Sep 4, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 4, 2023

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label Sep 4, 2023
@Krishnavamsi-wavelabs Krishnavamsi-wavelabs self-assigned this Sep 4, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 4, 2023 •
edited
Loading

Bazel unit-test results --config=production

    1 files  ±    0    86 suites   - 43   3m 16s ⏱️ -1s
412 tests  - 191  412 ✔️  - 191  0 💤 ±0  0 ❌ ±0 
413 runs   - 191  413 ✔️  - 191  0 💤 ±0  0 ❌ ±0 

Results for commit 109fb68. ± Comparison against base commit 2a7c062.

This pull request removes 193 and adds 2 tests. Note that renamed tests count towards both. 
ChargingGrantTest ‑ test_get_action
ChargingGrantTest ‑ test_get_action_redirect
ChargingGrantTest ‑ test_get_action_restrict
ChargingGrantTest ‑ test_get_update_type
ChargingGrantTest ‑ test_marshal
ChargingGrantTest ‑ test_should_deactivate_service
ChargingGrantTest ‑ test_tolerance_quota_exhausted
EventHandlerTest ‑ test_event_handler_close_assoc
EventHandlerTest ‑ test_event_handler_new_assoc
EventHandlerTest ‑ test_event_handler_send_ul
…

S1apMmeHandlersTest ‑ CheckEUTRANCGIPLMNSize
S1apMmeHandlersTest ‑ MissingRRCEstablishmentCauseIE

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 4, 2023 •
edited
Loading

Bazel unit-test results --config=asan

    1 files  ±    0    86 suites   - 43   3m 10s ⏱️ -9s
412 tests  - 191  412 ✔️  - 191  0 💤 ±0  0 ❌ ±0 
413 runs   - 191  413 ✔️  - 191  0 💤 ±0  0 ❌ ±0 

Results for commit 109fb68. ± Comparison against base commit 2a7c062.

This pull request removes 193 and adds 2 tests. Note that renamed tests count towards both. 
ChargingGrantTest ‑ test_get_action
ChargingGrantTest ‑ test_get_action_redirect
ChargingGrantTest ‑ test_get_action_restrict
ChargingGrantTest ‑ test_get_update_type
ChargingGrantTest ‑ test_marshal
ChargingGrantTest ‑ test_should_deactivate_service
ChargingGrantTest ‑ test_tolerance_quota_exhausted
EventHandlerTest ‑ test_event_handler_close_assoc
EventHandlerTest ‑ test_event_handler_new_assoc
EventHandlerTest ‑ test_event_handler_send_ul
…

S1apMmeHandlersTest ‑ CheckEUTRANCGIPLMNSize
S1apMmeHandlersTest ‑ MissingRRCEstablishmentCauseIE

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 4, 2023 •
edited
Loading

Bazel unit-test results

    1 files  ±    0    86 suites   - 146   3m 9s ⏱️ -19s
412 tests  - 312  412 ✔️  - 312  0 💤 ±0  0 ❌ ±0 
413 runs   - 312  413 ✔️  - 312  0 💤 ±0  0 ❌ ±0 

Results for commit 109fb68. ± Comparison against base commit 2a7c062.

This pull request removes 314 and adds 2 tests. Note that renamed tests count towards both. 
ChargingGrantTest ‑ test_get_action
ChargingGrantTest ‑ test_get_action_redirect
ChargingGrantTest ‑ test_get_action_restrict
ChargingGrantTest ‑ test_get_update_type
ChargingGrantTest ‑ test_marshal
ChargingGrantTest ‑ test_should_deactivate_service
ChargingGrantTest ‑ test_tolerance_quota_exhausted
EventHandlerTest ‑ test_event_handler_close_assoc
EventHandlerTest ‑ test_event_handler_new_assoc
EventHandlerTest ‑ test_event_handler_send_ul
…

S1apMmeHandlersTest ‑ CheckEUTRANCGIPLMNSize
S1apMmeHandlersTest ‑ MissingRRCEstablishmentCauseIE

♻️ This comment has been updated with latest results.

@Krishnavamsi-wavelabs Krishnavamsi-wavelabs force-pushed the topic/vamsi/sec-issue-10 branch 3 times, most recently from 713baf8 to 6ab1b6c Compare September 8, 2023 11:13
panyogesh
panyogesh approved these changes Sep 21, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@panyogesh panyogesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@panyogesh panyogesh merged commit 81e4e77 into master Sep 21, 2023
@panyogesh panyogesh deleted the topic/vamsi/sec-issue-10 branch September 21, 2023 07:26
lucasgonze pushed a commit to lucasgonze/magma that referenced this pull request Feb 29, 2024
@Krishnavamsi-wavelabs @lucasgonze
fix(mme): Handling Missing RRC Establishment Cause IE (magma#15299)
009b09b 
Signed-off-by: krishnavamsi-wavelabs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panyogesh panyogesh panyogesh approved these changes

@emakeev emakeev Awaiting requested review from emakeev emakeev is a code owner automatically assigned from magma/approvers-gw

Assignees

@Krishnavamsi-wavelabs Krishnavamsi-wavelabs

Labels

component: agw Access gateway-related issue size/M Denotes a PR that changes 30-99 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Krishnavamsi-wavelabs @panyogesh