Skip to content

fix(pipelined): QOS test cases pertaining to bitrate units#15291

Merged
panyogesh merged 1 commit intomagma:masterfrom
mehul-jindal:fix_sudo_tc
Aug 29, 2023
Merged

fix(pipelined): QOS test cases pertaining to bitrate units#15291
panyogesh merged 1 commit intomagma:masterfrom
mehul-jindal:fix_sudo_tc

Conversation

@mehul-jindal
Copy link
Copy Markdown
Contributor

@mehul-jindal mehul-jindal commented Aug 28, 2023

Summary

Fixes following degraded Pipelined - QOS test cases :

  • test_qos.py
  • test_qos_pyroute2.py

Test Plan

  • Tests run:
$MAGMA_ROOT/bazel/scripts/run_sudo_tests.sh

image

@mehul-jindal mehul-jindal self-assigned this Aug 28, 2023
@mehul-jindal mehul-jindal requested a review from a team as a code owner August 28, 2023 15:58
@mehul-jindal mehul-jindal requested a review from ssanadhya August 28, 2023 15:58
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label Aug 28, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 28, 2023

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label Aug 28, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 28, 2023

FeG Lint & Test

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0 ❌
388 runs  388 ✔️ 0 💤 0 ❌

Results for commit b1d30f3.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 28, 2023 •
edited
Loading

DP Lint & Test

14 tests   14 ✔️  2m 23s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit b1d30f3.

♻️ This comment has been updated with latest results.

@mehul-jindal mehul-jindal requested a review from panyogesh August 28, 2023 16:17
panyogesh
panyogesh approved these changes Aug 29, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@panyogesh panyogesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@panyogesh panyogesh merged commit 3f68ec9 into magma:master Aug 29, 2023
@mehul-jindal mehul-jindal deleted the fix_sudo_tc branch August 29, 2023 11:19
lucasgonze pushed a commit to lucasgonze/magma that referenced this pull request Feb 29, 2024
@mehul-jindal @lucasgonze
fix(pipelined): QOS test cases pertaining to bitrate units (magma#15291)
3e3578e 
Signed-off-by: mehul-jindal-wavelabs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panyogesh panyogesh panyogesh approved these changes

@ssanadhya ssanadhya Awaiting requested review from ssanadhya ssanadhya is a code owner automatically assigned from magma/approvers-gw

Assignees

@mehul-jindal mehul-jindal

Labels

component: agw Access gateway-related issue size/M Denotes a PR that changes 30-99 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mehul-jindal @panyogesh