Skip to content

fix(ci): drop version from referenced workflow#15219

Merged
maxhbr merged 1 commit intomagma:masterfrom
maxhbr:maxhbr/WorkOnMasterAfterForceMerge
Jun 20, 2023
Merged

fix(ci): drop version from referenced workflow#15219
maxhbr merged 1 commit intomagma:masterfrom
maxhbr:maxhbr/WorkOnMasterAfterForceMerge

Conversation

@maxhbr
Copy link
Copy Markdown
Member

@maxhbr maxhbr commented Jun 19, 2023

not sure if that will fix the problem in https://github.com/magma/magma/actions/runs/5313978394/workflow, but maybe it will help us to go forward with #15161

@maxhbr maxhbr requested a review from a team as a code owner June 19, 2023 19:55
@maxhbr maxhbr requested a review from ardzoht June 19, 2023 19:55
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Jun 19, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 19, 2023

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Jun 19, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 19, 2023

DP Lint & Test

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit d7963bd.

panyogesh
panyogesh approved these changes Jun 20, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@panyogesh panyogesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxhbr maxhbr merged commit 83f6c74 into magma:master Jun 20, 2023
This was referenced Jun 20, 2023
Closed
Closed
lucasgonze pushed a commit to lucasgonze/magma that referenced this pull request Feb 29, 2024
@maxhbr @lucasgonze
fix(ci): drop version from referenced workflow (magma#15219)
789ef45 
force merged with review by @panyogesh 

Signed-off-by: Maximilian Huber <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panyogesh panyogesh panyogesh approved these changes

@ardzoht ardzoht Awaiting requested review from ardzoht ardzoht is a code owner automatically assigned from magma/approvers-infra

Assignees

No one assigned

Labels

component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/XS Denotes a PR that changes 0-9 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maxhbr @panyogesh