Conversation
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
github-actions
bot
added
the
component: ci
|
✔️ The Semantic PR check ended with status success. See instructions on formatting your commit and pull request titles. |
panyogesh
changed the title
|
The changes look reasonable, lest see if it successfully posts the AGW build. Good work! Will review, once CI is done. |
|
the appropriate scope would probably be |
|
this is expected to close #15161 |
Signed-off-by: moyilakhila <[email protected]>
akhilamoyila9
force-pushed
the
topic/moyilakhila/fixcidashboard
branch
from
9d1c230 to
3341261
Compare
maxhbr
left a comment
maxhbr
left a comment
There was a problem hiding this comment.
This does not look like it is triggering the bazel builds.
| python ci-scripts/helm_repo_rotation.py | ||
|
|
||
| agw-build: | ||
| uses: ./.github/workflows/bazel.yml@master |
There was a problem hiding this comment.
Tha bazel jobs seem to not be kicked off correctly:
There was a problem hiding this comment.
Tha bazel jobs seem to not be kicked off correctly:
This will use the bazel.yml from master branch. The current file in Master branch is not a reusable workflow yet. Once the PR will be merged to the Master branch it will start working as expected.
There was a problem hiding this comment.
this was already tested? do you have links to runs in a fork where it worked or something like that?
There was a problem hiding this comment.
@tapasmishra : If you have already understood that it is good and have seen that it works, you could give the approval here?
There was a problem hiding this comment.
@maxhbr You can check this repo where I have a simple scenario on this issue : https://github.com/tapaswl/test_workflow/tree/main
There was a problem hiding this comment.
Ok, but then we can either force-merge this or first merge the changes to make bazel job callable with an independen PR first. Otherwise the merging will be blocked.
There was a problem hiding this comment.
I think force-merge will help to save duplicate works.
Signed-off-by: moyilakhila <[email protected]>
maxhbr
left a comment
maxhbr
left a comment
There was a problem hiding this comment.
Code looks sensible and @tapasmishra stated that it was tested and is working
|
this PR was reviewed by @lucasgonze for security implications |
Force merge, with go and review from @lucasgonze. * fix(ci): ci dashboard issue Signed-off-by: moyilakhila <[email protected]> * fix(ci): ci trigger for pull request Signed-off-by: moyilakhila <[email protected]> --------- Signed-off-by: moyilakhila <[email protected]> Co-authored-by: moyilakhila <[email protected]>
4 participants
Changes:
Test:
Summary
Test Plan
Additional Information
Security Considerations