chore: remove binaries for security#15179
Merged
lucasgonze merged 1 commit intomagma:masterfrom Apr 26, 2023
Merged
Conversation
Contributor
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
Contributor
Signed-off-by: Lucas Gonze <[email protected]>
lucasgonze
force-pushed
the
chore-security-144-remove-binaries
branch
from
dfbd60e to
10c4529
Compare
lucasgonze
added a commit
to lucasgonze/magma
that referenced
this pull request
Feb 29, 2024
Signed-off-by: Lucas Gonze <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Binary artifacts in source control are a security risk. See https://github.com/ossf/scorecard/blob/e42af756609b2cde6d757fd45ea05ddf0016ff62/docs/checks.md#binary-artifacts
Removed as part of https://github.com/magma/security/issues/144
Test Plan
Discussed with TSC to verify that neither of the two tools removed are still used.
Additional Information
Security Considerations
A net improvement to security. Issue identified using OpenSSF Security Scorecard.