Conversation
Contributor
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
github-actions
bot
added
component: agw
Contributor
|
✔️ The Semantic PR check ended with status success. See instructions on formatting your commit and pull request titles. |
pull-request-size
bot
added
size/L
Contributor
CWF integration test results 1 files ±0 1 suites ±0 16m 42s ⏱️ + 5m 50s For more details on these failures, see this check. Results for commit 67a6fac. ± Comparison against base commit 6368195. ♻️ This comment has been updated with latest results. |
MoritzThomasHuebner
force-pushed
the
go_upgrade
branch
from
9593ef6 to
392b57e
Compare
MoritzThomasHuebner
requested review from
VinashakAnkitAman,
ajahl and
alexzurbonsen
MoritzThomasHuebner
force-pushed
the
go_upgrade
branch
from
392b57e to
6f47b6b
Compare
Contributor
voisey
approved these changes
Mar 9, 2023
Co-authored-by: Sebastian Wolf <[email protected]> Signed-off-by: Moritz Huebner <[email protected]>
ci, docker, ansible Co-authored-by: Sebastian Wolf <[email protected]> Signed-off-by: Moritz Huebner <[email protected]>
Co-authored-by: Sebastian Wolf <[email protected]> Signed-off-by: Moritz Huebner <[email protected]>
Needed for go1.20 Co-authored-by: Sebastian Wolf <[email protected]> Signed-off-by: Moritz Huebner <[email protected]>
Co-authored-by: Sebastian Wolf <[email protected]> Signed-off-by: Moritz Huebner <[email protected]>
MoritzThomasHuebner
force-pushed
the
go_upgrade
branch
from
6f47b6b to
67a6fac
Compare
lucasgonze
pushed a commit
to lucasgonze/magma
that referenced
this pull request
Feb 29, 2024
* chore(orc8r): Increment go version Co-authored-by: Sebastian Wolf <[email protected]> Signed-off-by: Moritz Huebner <[email protected]> * chore(orc8r): Increment go version in configs ci, docker, ansible Co-authored-by: Sebastian Wolf <[email protected]> Signed-off-by: Moritz Huebner <[email protected]> * chore(orc8r): Increment go version in go.mod Co-authored-by: Sebastian Wolf <[email protected]> Signed-off-by: Moritz Huebner <[email protected]> * chore(orc8r): Upgrade golangci-lint Needed for go1.20 Co-authored-by: Sebastian Wolf <[email protected]> Signed-off-by: Moritz Huebner <[email protected]> * chore(orc8r): Changed golang versions to 1.20 where missing Co-authored-by: Sebastian Wolf <[email protected]> Signed-off-by: Moritz Huebner <[email protected]> --------- Signed-off-by: Moritz Huebner <[email protected]> Co-authored-by: Sebastian Wolf <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
CWF Integ tests:https://github.com/magma/magma/actions/runs/4421543919
FeG Integ tests: https://github.com/magma/magma/actions/runs/4360375418
Local connect orc8r to AGW
Deploy on minikube
CI green