feat(agw): set up containerized agw with fabric#15132
Merged
LKreutzer merged 4 commits intomagma:masterfrom Mar 13, 2023
Merged
feat(agw): set up containerized agw with fabric#15132LKreutzer merged 4 commits intomagma:masterfrom
LKreutzer merged 4 commits intomagma:masterfrom
Conversation
Contributor
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
github-actions
bot
added
component: agw
Contributor
|
✔️ The Semantic PR check ended with status success. See instructions on formatting your commit and pull request titles. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
wolfseb
changed the title
Contributor
Closed
6 tasks
Contributor
added 4 commits
March 7, 2023 11:54
Signed-off-by: Sebastian Wolf <[email protected]>
Signed-off-by: Sebastian Wolf <[email protected]>
* remove superfluous comment * add Args in docstrings Signed-off-by: Sebastian Wolf <[email protected]>
Signed-off-by: Sebastian Wolf <[email protected]>
wolfseb
force-pushed
the
set_up_containerized_agw_with_fabric
branch
from
2350161 to
0e9fcab
Compare
MoritzThomasHuebner
approved these changes
Mar 8, 2023
Contributor
|
@LKreutzer maybe you can review this as well. |
LKreutzer
reviewed
Mar 9, 2023
Contributor
LKreutzer
left a comment
LKreutzer
left a comment
There was a problem hiding this comment.
I started some integ test runs on a copy branch:
- https://github.com/magma/magma/actions/runs/4373139879
- https://github.com/magma/magma/actions/runs/4373140797
- https://github.com/magma/magma/actions/runs/4373142111
Contributor
Contributor
LTE containerizes integ test results - extended_tests46 tests +46 42 ✔️ +42 1h 47m 40s ⏱️ + 1h 47m 40s For more details on these failures, see this check. Results for commit 0e9fcab. ± Comparison against base commit 8b770fd. ♻️ This comment has been updated with latest results. |
Contributor
LTE containerizes integ test results - precommit121 tests +1 119 ✔️ ±0 2h 38m 0s ⏱️ + 39m 14s For more details on these failures, see this check. Results for commit 0e9fcab. ± Comparison against base commit 8b770fd. ♻️ This comment has been updated with latest results. |
Contributor
Looks like the tests are okay. |
lucasgonze
pushed a commit
to lucasgonze/magma
that referenced
this pull request
Feb 29, 2024
* feat(agw): set up containerized agw with fabric Signed-off-by: Sebastian Wolf <[email protected]> * docs: add fab command for containerized agw Signed-off-by: Sebastian Wolf <[email protected]> * chore(agw): format containerized gateway setup * remove superfluous comment * add Args in docstrings Signed-off-by: Sebastian Wolf <[email protected]> * docs: specify language for fenced code block Signed-off-by: Sebastian Wolf <[email protected]> --------- Signed-off-by: Sebastian Wolf <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #14909 .
Summary
Introduces a fabric command to setup the dockerized AGW for convenience.
Test Plan
Setup the dockerized AGW with the fabric command
fab start-gateway-containerizedand check the containers functionality.Additional Information