fix(ci): evaluate dry run condition correctly#15131
Merged
mpfirrmann merged 1 commit intomagma:masterfrom Mar 6, 2023
mpfirrmann:pr/dry_run_condition
Merged
fix(ci): evaluate dry run condition correctly#15131mpfirrmann merged 1 commit intomagma:masterfrom mpfirrmann:pr/dry_run_condition
mpfirrmann merged 1 commit intomagma:masterfrom
mpfirrmann:pr/dry_run_condition
Conversation
Signed-off-by: Marco Pfirrmann <[email protected]>
Contributor
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
github-actions
bot
added
the
component: ci
Contributor
LKreutzer
approved these changes
Mar 6, 2023
lucasgonze
pushed a commit
to lucasgonze/magma
that referenced
this pull request
Feb 29, 2024
Signed-off-by: Marco Pfirrmann <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#15098 introduced a bug, where the dry run condition in the Bazel workflow was evaluated incorrectly. This fixes it.
Test Plan
Tested on my fork with adapted
github.repository_owner == 'mpfirrmann'.See also the tests on the mentioned PR, linked in this conversation.
Additional Information