Skip to content

fix(ci): add quotation marks to client payload#15120

Merged
mpfirrmann merged 1 commit intomagma:masterfrom
mpfirrmann:pr/payload_quotation
Mar 3, 2023
Merged

fix(ci): add quotation marks to client payload#15120
mpfirrmann merged 1 commit intomagma:masterfrom
mpfirrmann:pr/payload_quotation

Conversation

@mpfirrmann
Copy link
Copy Markdown
Contributor

@mpfirrmann mpfirrmann commented Mar 3, 2023

Summary

Fixes a bug where missing quotation marks in the client payload introduced an error, leading to workflows not being triggered correctly. See for example the error message in the last run.

Test Plan

Additional Information

  • This change is backwards-breaking

@mpfirrmann mpfirrmann requested a review from LKreutzer March 3, 2023 07:01
@mpfirrmann mpfirrmann requested a review from a team as a code owner March 3, 2023 07:01
@mpfirrmann mpfirrmann self-assigned this Mar 3, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Mar 3, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 3, 2023

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Mar 3, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 3, 2023

DP Lint & Test

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 49267b4.

@mpfirrmann mpfirrmann merged commit 7e87010 into magma:master Mar 3, 2023
@mpfirrmann mpfirrmann deleted the pr/payload_quotation branch March 3, 2023 07:47
mpfirrmann added a commit that referenced this pull request Mar 3, 2023
@mpfirrmann
Revert "fix(ci): failure slack message will display commit message (#…
ba55b5b 
…15109)" (#15123)

* Revert "fix(ci): add quotation marks to client payload (#15120)"

This reverts commit 7e87010.

* Revert "fix(ci): failure slack message will display commit message (#15109)"

This reverts commit 5f00d95.
lucasgonze pushed a commit to lucasgonze/magma that referenced this pull request Feb 29, 2024
@mpfirrmann @lucasgonze
fix(ci): add quotation marks to client payload (magma#15120)
954c6f5 
Signed-off-by: Marco Pfirrmann <[email protected]>
lucasgonze pushed a commit to lucasgonze/magma that referenced this pull request Feb 29, 2024
@mpfirrmann @lucasgonze
Revert "fix(ci): failure slack message will display commit message (m…
ad5bf27 
…agma#15109)" (magma#15123)

* Revert "fix(ci): add quotation marks to client payload (magma#15120)"

This reverts commit 7e87010.

* Revert "fix(ci): failure slack message will display commit message (magma#15109)"

This reverts commit 5f00d95.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@voisey voisey voisey approved these changes

@LKreutzer LKreutzer Awaiting requested review from LKreutzer

Assignees

@mpfirrmann mpfirrmann

Labels

component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/XS Denotes a PR that changes 0-9 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mpfirrmann @voisey