Skip to content

fix(ci): failure slack message will display commit message#15109

Merged
mpfirrmann merged 2 commits intomagma:masterfrom
mpfirrmann:pr/slack_commit_dispatch
Mar 2, 2023
Merged

fix(ci): failure slack message will display commit message#15109
mpfirrmann merged 2 commits intomagma:masterfrom
mpfirrmann:pr/slack_commit_dispatch

Conversation

@mpfirrmann
Copy link
Copy Markdown
Contributor

@mpfirrmann mpfirrmann commented Mar 1, 2023

Summary

Failing CI jobs send a message to the #ci Slack channel. This message is structured as:
"$TEST_NAME failed in run $RUN_ID from commit $COMMIT_HASH: $COMMIT_MESSAGE"

Workflows which are triggered via a repository_dispatch trigger, Magma Build, Publish & Test Federated Integration, AGW Test LTE Integration With Bazel Debian Build, and AGW Test LTE Integration With Make Debian Build miss the $COMMIT_MESSAGE information. This results in their slack messages ending after the colon.

In order to fix this, the $COMMIT_MESSAGE information is parsed to these workflows via client_payload.

Test Plan

Additional Information

  • This change is backwards-breaking

…all-artifact repository dispatch workflows

Signed-off-by: Marco Pfirrmann <[email protected]>
…debian-artifact repository dispatch workflows

Signed-off-by: Marco Pfirrmann <[email protected]>
@mpfirrmann mpfirrmann requested a review from a team as a code owner March 1, 2023 15:30
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines. label Mar 1, 2023
@mpfirrmann mpfirrmann changed the title fix(ci): failure slack message will display commit message for build-… …all-artifact repository dispatch workflows fix(ci): failure slack message will display commit message for repository dispatch workflows Mar 1, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 1, 2023

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Mar 1, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 1, 2023

✔️ The Semantic PR check ended with status success. See instructions on formatting your commit and pull request titles.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 1, 2023

DP Lint & Test

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 5b8687d.

@mpfirrmann mpfirrmann changed the title fix(ci): failure slack message will display commit message for repository dispatch workflows fix: failure slack message will display commit message for repository dispatch workflows Mar 1, 2023
@mpfirrmann mpfirrmann changed the title fix: failure slack message will display commit message for repository dispatch workflows fix: failure slack message will display commit message Mar 1, 2023
@mpfirrmann mpfirrmann changed the title fix: failure slack message will display commit message ci: failure slack message will display commit message Mar 1, 2023
@mpfirrmann mpfirrmann changed the title ci: failure slack message will display commit message fix(ci): failure slack message will display commit message Mar 1, 2023
@mpfirrmann mpfirrmann self-assigned this Mar 1, 2023
Comment thread .github/workflows/build_all.yml
@mpfirrmann mpfirrmann merged commit 5f00d95 into magma:master Mar 2, 2023
@mpfirrmann mpfirrmann deleted the pr/slack_commit_dispatch branch March 2, 2023 13:22
mpfirrmann added a commit that referenced this pull request Mar 3, 2023
…15109)" (#15123)

* Revert "fix(ci): add quotation marks to client payload (#15120)"

This reverts commit 7e87010.

* Revert "fix(ci): failure slack message will display commit message (#15109)"

This reverts commit 5f00d95.
lucasgonze pushed a commit to lucasgonze/magma that referenced this pull request Feb 29, 2024
* fix(ci): failure slack message will display commit message for build-all-artifact repository dispatch workflows

Signed-off-by: Marco Pfirrmann <[email protected]>

* fix(ci): failure slack message will display commit message for magma-debian-artifact repository dispatch workflows

Signed-off-by: Marco Pfirrmann <[email protected]>

---------

Signed-off-by: Marco Pfirrmann <[email protected]>
lucasgonze pushed a commit to lucasgonze/magma that referenced this pull request Feb 29, 2024
…agma#15109)" (magma#15123)

* Revert "fix(ci): add quotation marks to client payload (magma#15120)"

This reverts commit 7e87010.

* Revert "fix(ci): failure slack message will display commit message (magma#15109)"

This reverts commit 5f00d95.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/S Denotes a PR that changes 10-29 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants