chore(ci): improve wemake workflow logging#15105
chore(ci): improve wemake workflow logging#15105mpfirrmann merged 1 commit intomagma:masterfrom mpfirrmann:pr/weemake_logging
Conversation
Signed-off-by: Marco Pfirrmann <[email protected]>
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
github-actions
bot
added
the
component: ci
| - name: Info for local execution | ||
| if: failure() | ||
| run: | | ||
| echo "Running linting tools failed. This should be equivalent to running './lte/gateway/python/precommit.py --lint --diff' locally." |
There was a problem hiding this comment.
Is this actually equivalent given that the wemake-python-styleguide action outputs comments for entire edited files? Is this what ./lte/gateway/python/precommit.py --lint --diff does?
There was a problem hiding this comment.
My understanding is that the wemake styleguide was added to the docker container running with the precommit.py with #14994 and that the edited files are checked entirely. Or am I mistaken @LKreutzer?
There was a problem hiding this comment.
Locally only the last commit is checked and in CI everything up to the merge-base, but otherwise they should be identical.
There was a problem hiding this comment.
I just tested this locally with two commits in which I introduced linting errors, and the errors for both commits were reported, so it looks good to me.
MoritzThomasHuebner
changed the title
Signed-off-by: Marco Pfirrmann <[email protected]>
4 participants
Summary
Improve the weemake workflow to echo a hint for local linting.
This code change was separated from #14831 to simplify code review.
Test Plan
Additional Information