chore: Build the Python services with Bazel for the FEG Docker images by LKreutzer · Pull Request #15103 · magma/magma

LKreutzer · 2023-02-28T15:52:15Z

Summary

Build the Python services with Bazel for the FEG Docker images
- magmad and eventd are used here
- FEG swagger specs and the docker_upgrader.py are only used for the FEG and thus were not bazelified yet. They are needed for the Python services to run in this setup.
Resolves Use bazel-built services in feg/gateway/docker/python/Dockerfile #15042

Test Plan

FEG integ:

LTE integ:

Additional Information

This change is backwards-breaking

github-actions · 2023-02-28T15:52:35Z

Thanks for opening a PR! 💯

A couple initial guidelines

All commits must be signed off. This is enforced by PR DCO check.
All PR titles must follow the semantic commits format. This is enforced by PR Check Title Or Commit Message.

Howto

Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
Checks. All required CI checks must pass before merge.
Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

Contributing Conventions for norms around contributed code

If this is your first Magma PR, also consider reading

Developer Onboarding for onboarding as a new Magma developer
Development Workflow for guidance on your first PR
CI Checks for points of contact for failing or flaky CI checks
Code Review Process for information on requesting reviews and contacting maintainers

github-actions · 2023-02-28T15:53:58Z

-
-RUN apt-get -y update && apt-get -y install python3.8
+# Install the build deps with apt.
+RUN apt-get -y update && apt-get -y install \


⚠️ [hadolint] <DL3008> _{reported by reviewdog 🐶}
Pin versions in apt get install. Instead of apt-get install <package> use apt-get install <package>=<version>

github-actions · 2023-02-28T15:53:59Z

-RUN apt-get -y update && apt-get -y install python3.8
+# Install the build deps with apt.
+RUN apt-get -y update && apt-get -y install \
+    apt-transport-https \


📝 [hadolint] <DL3015> _{reported by reviewdog 🐶}
Avoid additional packages by specifying --no-install-recommends

github-actions · 2023-02-28T15:58:03Z

Bazel unit-test results --config=asan

1 files ±    0 0 suites - 129 0s ⏱️ - 3m 13s
0 tests - 598 0 ✔️ - 598 0 💤 ±0 0 ❌ ±0
0 runs - 599 0 ✔️ - 599 0 💤 ±0 0 ❌ ±0

Results for commit fd23fc7. ± Comparison against base commit f70b351.

♻️ This comment has been updated with latest results.

github-actions · 2023-02-28T15:58:32Z

Bazel unit-test results --config=production

1 files ±    0 0 suites - 129 0s ⏱️ - 3m 14s
0 tests - 598 0 ✔️ - 598 0 💤 ±0 0 ❌ ±0
0 runs - 599 0 ✔️ - 599 0 💤 ±0 0 ❌ ±0

Results for commit fd23fc7. ± Comparison against base commit f70b351.

♻️ This comment has been updated with latest results.

github-actions · 2023-02-28T15:58:41Z

Bazel unit-test results

1 files ±    0 3 suites - 229 1s ⏱️ - 3m 13s
3 tests - 716 3 ✔️ - 716 0 💤 ±0 0 ❌ ±0
3 runs - 717 3 ✔️ - 717 0 💤 ±0 0 ❌ ±0

Results for commit fd23fc7. ± Comparison against base commit f70b351.

This pull request removes 716 tests.

AMFAppProcedureTest ‑ GnbInitiatedNGReset
AMFAppProcedureTest ‑ ImplicitDeregDuplicateSuciReg
AMFAppProcedureTest ‑ PeriodicRegistraionNoTmsi
AMFAppProcedureTest ‑ ReRegistraion
AMFAppProcedureTest ‑ RegistrationAfterFourRegAcceptMsgs
AMFAppProcedureTest ‑ SctpShutWithServiceRequest
AMFAppProcedureTest ‑ ServiceRequestHighPriority
AMFAppProcedureTest ‑ ServiceRequestMTWithPDU
AMFAppProcedureTest ‑ ServiceRequestMTWithoutUplinkDataStatus
AMFAppProcedureTest ‑ ServiceRequestSignalWithPDU
…

♻️ This comment has been updated with latest results.

github-actions · 2023-02-28T17:04:01Z

LTE containerizes integ test results - extended_tests

46 tests ±0 45 ✔️ - 1 1h 33m 22s ⏱️ + 24m 8s
46 suites ±0   0 💤 ±0
46 files ±0   1 ❌ +1

For more details on these failures, see this check.

Results for commit fd23fc7. ± Comparison against base commit f70b351.

♻️ This comment has been updated with latest results.

github-actions · 2023-02-28T17:29:14Z

FEG integration test results

32 tests ±0 32 ✔️ +1 19m 1s ⏱️ - 10m 58s
32 suites ±0   0 💤 ±0
32 files ±0   0 ❌ - 1

Results for commit fd23fc7. ± Comparison against base commit f70b351.

♻️ This comment has been updated with latest results.

github-actions · 2023-02-28T18:03:51Z

LTE containerizes integ test results - extended_tests_long

6 tests +6 6 ✔️ +6 46m 7s ⏱️ + 46m 7s
6 suites +6 0 💤 ±0
6 files +6 0 ❌ ±0

Results for commit fd23fc7. ± Comparison against base commit f70b351.

♻️ This comment has been updated with latest results.

github-actions · 2023-02-28T18:38:42Z

LTE containerizes integ test results - precommit

121 tests ±0 118 ✔️ - 1 2h 37m 27s ⏱️ + 30m 30s
121 suites ±0     1 💤 ±0
121 files ±0     2 ❌ +1

For more details on these failures, see this check.

Results for commit fd23fc7. ± Comparison against base commit f70b351.

♻️ This comment has been updated with latest results.

LKreutzer · 2023-03-02T12:31:41Z

  "./orc8r/cloud/deploy"
  "./orc8r/cloud/docker"
  # is not relevant for AGW
-  "./orc8r/gateway/python/magma/magmad/upgrade/docker_upgrader.py"


I added this change, since this file is actually bazelified in this PR.

mpfirrmann

LGTM

LKreutzer · 2023-03-02T14:27:14Z

Rebased

Signed-off-by: Lars Kreutzer <[email protected]>

LKreutzer · 2023-03-02T15:35:57Z

The changes to feg/swagger require a change in the LTE containerized integ tests.

LTE integ test runs:

FEG integ:

…magma#15103) Signed-off-by: Lars Kreutzer <[email protected]>

LKreutzer added component: ci All updates on CI (Jenkins/CircleCi/Github Action) component: feg FEG-gateway related issues bazel changes for the Bazelification effort labels Feb 28, 2023

LKreutzer self-assigned this Feb 28, 2023

pull-request-size bot added the size/L Denotes a Pull Request that changes 100-499 lines. label Feb 28, 2023

github-actions bot added the component: orc8r Orchestrator-related issue label Feb 28, 2023

github-actions bot reviewed Feb 28, 2023

View reviewed changes

LKreutzer marked this pull request as ready for review March 1, 2023 07:26

LKreutzer requested review from a team as code owners March 1, 2023 07:26

LKreutzer requested review from mpfirrmann, vktng and voisey and removed request for vktng March 1, 2023 07:26

LKreutzer force-pushed the python_feg_docker_bazel branch from 047e60e to cf458b2 Compare March 1, 2023 08:04

MoritzThomasHuebner requested changes Mar 2, 2023

View reviewed changes

Comment thread feg/gateway/docker/python/Dockerfile

Comment thread feg/gateway/docker/python/Dockerfile Outdated

LKreutzer force-pushed the python_feg_docker_bazel branch 2 times, most recently from 45b2075 to 4d01467 Compare March 2, 2023 12:31

LKreutzer commented Mar 2, 2023

View reviewed changes

mpfirrmann approved these changes Mar 2, 2023

View reviewed changes

LKreutzer requested a review from MoritzThomasHuebner March 2, 2023 14:16

LKreutzer force-pushed the python_feg_docker_bazel branch from 4d01467 to 2fadc46 Compare March 2, 2023 14:27

chore: Build the Python services with Bazel for the FEG Docker images

fd23fc7

Signed-off-by: Lars Kreutzer <[email protected]>

LKreutzer force-pushed the python_feg_docker_bazel branch from 2fadc46 to fd23fc7 Compare March 2, 2023 15:33

MoritzThomasHuebner approved these changes Mar 3, 2023

View reviewed changes

LKreutzer merged commit 7ae3e9a into master Mar 3, 2023

LKreutzer deleted the python_feg_docker_bazel branch March 3, 2023 08:26

lucasgonze pushed a commit to lucasgonze/magma that referenced this pull request Feb 29, 2024

chore: Build the Python services with Bazel for the FEG Docker images (…

5fdc9ae

…magma#15103) Signed-off-by: Lars Kreutzer <[email protected]>

Conversation

LKreutzer commented Feb 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test Plan

Additional Information

Uh oh!

github-actions bot commented Feb 28, 2023

Howto

More info

Uh oh!

github-actions bot Feb 28, 2023

Choose a reason for hiding this comment

Uh oh!

github-actions bot Feb 28, 2023

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bazel unit-test results --config=asan

Uh oh!

github-actions bot commented Feb 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bazel unit-test results --config=production

Uh oh!

github-actions bot commented Feb 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bazel unit-test results

Uh oh!

github-actions bot commented Feb 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

LTE containerizes integ test results - extended_tests

Uh oh!

github-actions bot commented Feb 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

FEG integration test results

Uh oh!

github-actions bot commented Feb 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

LTE containerizes integ test results - extended_tests_long

Uh oh!

github-actions bot commented Feb 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

LTE containerizes integ test results - precommit

Uh oh!

Uh oh!

Uh oh!

LKreutzer Mar 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mpfirrmann left a comment

Choose a reason for hiding this comment

Uh oh!

LKreutzer commented Mar 2, 2023

Uh oh!

LKreutzer commented Mar 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

LKreutzer commented Feb 28, 2023 •

edited

Loading

github-actions bot commented Feb 28, 2023 •

edited

Loading

github-actions bot commented Feb 28, 2023 •

edited

Loading

github-actions bot commented Feb 28, 2023 •

edited

Loading

github-actions bot commented Feb 28, 2023 •

edited

Loading

github-actions bot commented Feb 28, 2023 •

edited

Loading

github-actions bot commented Feb 28, 2023 •

edited

Loading

github-actions bot commented Feb 28, 2023 •

edited

Loading

LKreutzer Mar 2, 2023 •

edited

Loading

LKreutzer commented Mar 2, 2023 •

edited

Loading