Skip to content

docs: Add missing AGW technical reference pages to sidebars#15078

Merged
voisey merged 1 commit intomagma:masterfrom
voisey:sidebars-agw-tech-ref
Feb 24, 2023
Merged

docs: Add missing AGW technical reference pages to sidebars#15078
voisey merged 1 commit intomagma:masterfrom
voisey:sidebars-agw-tech-ref

Conversation

@voisey
Copy link
Copy Markdown
Contributor

@voisey voisey commented Feb 24, 2023

Summary

Related to #14958. Adds three AGW pages that were not being displayed properly to the sidebars. This fixes the problem for master and the supported releases (1.7, 1.8).

Test Plan

  • Ran cd $MAGMA_ROOT/docs && make dev successfully locally
  • Checked that for each of the modified versions (1.7, 1.8, master), the pages appear in the sidebar as expected

@voisey voisey requested a review from a team as a code owner February 24, 2023 14:09
@voisey voisey requested a review from tmdzk February 24, 2023 14:09
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines. label Feb 24, 2023
@github-actions
Copy link
Copy Markdown
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: docs Documentation-related issue label Feb 24, 2023
@voisey voisey self-assigned this Feb 24, 2023
@github-actions
Copy link
Copy Markdown
Contributor

DP Lint & Test

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit afb50a0.

Copy link
Copy Markdown
Contributor

@mpfirrmann mpfirrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, linked pages appear in sidebar.

@voisey voisey merged commit 9e398a6 into magma:master Feb 24, 2023
lucasgonze pushed a commit to lucasgonze/magma that referenced this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: docs Documentation-related issue size/S Denotes a PR that changes 10-29 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants