chore(ci): docker images are published with release tags#15076
Merged
mpfirrmann merged 1 commit intomagma:masterfrom Feb 27, 2023
mpfirrmann:pr/tags_container
Merged
chore(ci): docker images are published with release tags#15076mpfirrmann merged 1 commit intomagma:masterfrom mpfirrmann:pr/tags_container
mpfirrmann merged 1 commit intomagma:masterfrom
mpfirrmann:pr/tags_container
Conversation
Contributor
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
github-actions
bot
added
the
component: ci
Contributor
mpfirrmann
requested review from
LKreutzer and
talkhasib
and removed request for
talkhasib
LKreutzer
reviewed
Feb 27, 2023
Contributor
LKreutzer
left a comment
LKreutzer
left a comment
There was a problem hiding this comment.
Should we also refactor the build-containers-ghz job since it also publishes?
Signed-off-by: Marco Pfirrmann <[email protected]>
Contributor
Author
I adapted the |
LKreutzer
approved these changes
Feb 27, 2023
lucasgonze
pushed a commit
to lucasgonze/magma
that referenced
this pull request
Feb 29, 2024
Signed-off-by: Marco Pfirrmann <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Magma debian packages are released for every merge to master and release branches. They are tagged with
latestplus either commit hash (master branch) or release version number (release branch). This behavior is mimicked here for magma containers. At the moment, they are only published with thelatesttag and commit hash.Closes #15040.
Test Plan
The GitHub action was adapted to only perform the tag handling and executed on my fork (see the adapted test via the commit hash on the links)
v1.9branch created on my fork specifically for this testAdditional Information
The final output tag is written into $GITHUB_OUTPUT in a different step now.