chore(ci): Update PR Generate Hello message#15037
Merged
voisey merged 1 commit intomagma:masterfrom Feb 24, 2023
Merged
Conversation
Signed-off-by: Cameron Voisey <[email protected]>
Contributor
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
github-actions
bot
added
the
component: ci
Contributor
LKreutzer
approved these changes
Feb 22, 2023
Contributor
LKreutzer
left a comment
LKreutzer
left a comment
There was a problem hiding this comment.
Unfortunately the magma teams/approver groups do not seem to be publicly visible - I don't know if updating the approver list in the Wiki is a sustainable solution?
Gmerold
added a commit
to Gmerold/magma
that referenced
this pull request
Feb 24, 2023
This reverts commit 478ff46. Signed-off-by: Bartlomiej Gmerek <[email protected]>
lucasgonze
pushed a commit
to lucasgonze/magma
that referenced
this pull request
Feb 29, 2024
Signed-off-by: Cameron Voisey <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #14967.
Tidies up the PR bot message by:
I also propose making the following modification to the opening paragraph of Code Review Process:
"A personal message on Slack should only be the last resort, if there is no response on a pull request after a weeks time."
->
"A personal message on Slack should only be the last resort, if there is no response on a pull request after a week's time. In such cases, the GitHub-to-Slack mapping may be useful."
as well as opening a follow-up issue to update the aforementioned list.
Test Plan
N/A