Revert "refactor(agw): Minor improvements to the fabfiles (#15004)"#15030
Merged
nstng merged 1 commit intomagma:masterfrom Feb 20, 2023
Merged
Revert "refactor(agw): Minor improvements to the fabfiles (#15004)"#15030nstng merged 1 commit intomagma:masterfrom
nstng merged 1 commit intomagma:masterfrom
Conversation
This reverts commit 96bd8e3. Signed-off-by: Nils Semmelrock <[email protected]>
pull-request-size
bot
added
the
size/L
Contributor
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
github-actions
bot
added
component: agw
LKreutzer
approved these changes
Feb 20, 2023
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
Contributor
voisey
approved these changes
Feb 20, 2023
MoritzThomasHuebner
added a commit
to MoritzThomasHuebner/magma
that referenced
this pull request
Feb 21, 2023
…gma#15004)" (magma#15030)" This reverts commit 4802e7c. Signed-off-by: Moritz Huebner <[email protected]>
This was referenced Feb 21, 2023
Closed
MoritzThomasHuebner
added a commit
that referenced
this pull request
Feb 22, 2023
* Revert "Revert "refactor(agw): Minor improvements to the fabfiles (#15004)" (#15030)" This reverts commit 4802e7c. Signed-off-by: Moritz Huebner <[email protected]> * chore(agw): Fixed hash/commit_hash clash Signed-off-by: Moritz Huebner <[email protected]> --------- Signed-off-by: Moritz Huebner <[email protected]>
lucasgonze
pushed a commit
to lucasgonze/magma
that referenced
this pull request
Feb 29, 2024
…" (magma#15030) This reverts commit 96bd8e3. Signed-off-by: Nils Semmelrock <[email protected]>
lucasgonze
pushed a commit
to lucasgonze/magma
that referenced
this pull request
Feb 29, 2024
* Revert "Revert "refactor(agw): Minor improvements to the fabfiles (magma#15004)" (magma#15030)" This reverts commit 4802e7c. Signed-off-by: Moritz Huebner <[email protected]> * chore(agw): Fixed hash/commit_hash clash Signed-off-by: Moritz Huebner <[email protected]> --------- Signed-off-by: Moritz Huebner <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 96bd8e3.
Summary
#15004 broke the agw build, see https://github.com/magma/magma/actions/runs/4221022707/jobs/7327856886
Test Plan
CI
Additional Information