chore(cwg): Remove unused code from CWF fabfile#15023
Merged
MoritzThomasHuebner merged 1 commit intomagma:masterfrom Feb 16, 2023
Merged
chore(cwg): Remove unused code from CWF fabfile#15023MoritzThomasHuebner merged 1 commit intomagma:masterfrom
MoritzThomasHuebner merged 1 commit intomagma:masterfrom
Conversation
Signed-off-by: Cameron Voisey <[email protected]>
Contributor
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
Contributor
lucasgonze
pushed a commit
to lucasgonze/magma
that referenced
this pull request
Feb 29, 2024
Signed-off-by: Cameron Voisey <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In #14806 a change was made to the indentation of the logging and exiting here, which means that the logging and exiting here will never be executed. One option would be to revert this behaviour, but here I have chosen to simply remove the surplus lines so that the exiting is only handled in one place. Let me know if you prefer a different solution.
I also amended the print statement slightly to make it a bit clearer.
Test Plan
N/A