refactor(agw): Improved error handling in fabfiles#15020
Merged
MoritzThomasHuebner merged 1 commit intomagma:masterfrom Feb 20, 2023
Merged
Conversation
Contributor
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
Closed
6 tasks
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
|
Oops! Looks like you failed the Howto
♻️ Updated: ✅ The check is passing the AGW Build & Format Python after the last commit. |
Contributor
Contributor
MoritzThomasHuebner
force-pushed
the
improve_error_handling_in_fabfiles
branch
from
2ab2ff3 to
e67f919
Compare
- Use `sys.exit()` to exit fabfile instead of `raise` - Specified possible exceptions in a broad exception clause Signed-off-by: Moritz Huebner <[email protected]>
MoritzThomasHuebner
force-pushed
the
improve_error_handling_in_fabfiles
branch
from
e67f919 to
746d04c
Compare
MoritzThomasHuebner
changed the title
Contributor
lucasgonze
pushed a commit
to lucasgonze/magma
that referenced
this pull request
Feb 29, 2024
- Use `sys.exit()` to exit fabfile instead of `raise` - Specified possible exceptions in a broad exception clause Signed-off-by: Moritz Huebner <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sys.exit()to exit fabfile instead ofraiseTest Plan
exceptclause causes any issues. Had to run this on the magma repo because my fork would keep stalling on this action. https://github.com/magma/magma/actions/runs/4190438126