Skip to content

fix(orc8r): Fixing the missing folder for prometheus rule configuration#15001

Merged
jordanvrtanoski merged 2 commits intomagma:masterfrom
jordanvrtanoski:fix_14995
Jun 26, 2023
Merged

fix(orc8r): Fixing the missing folder for prometheus rule configuration#15001
jordanvrtanoski merged 2 commits intomagma:masterfrom
jordanvrtanoski:fix_14995

Conversation

@jordanvrtanoski
Copy link
Copy Markdown
Contributor

The issue #14995 is caused by a missing folder alert_rules in the prometheus configuration folder. The alertmanager-configurer will create the folder with restrictive access rights which will prevent prometheus and alertmanager to read the configuration.

Signed-off-by: Jordan Vrtanoski [email protected]

The issue magma#14995 is caused by a missing folder `alert_rules` in the prometheus configuration folder. The `alertmanager-configurer` will create the folder with restrictive access rights which will prevent `prometheus` and `alertmanager` to read the configuration.

Signed-off-by: Jordan Vrtanoski <[email protected]>
@jordanvrtanoski jordanvrtanoski requested a review from a team as a code owner February 13, 2023 12:55
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Feb 13, 2023
@github-actions
Copy link
Copy Markdown
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: orc8r Orchestrator-related issue label Feb 13, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 13, 2023

FeG Lint & Test

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0
388 runs  388 ✔️ 0 💤 0

Results for commit d976137.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 13, 2023

DP Lint & Test

14 tests   14 ✔️  2m 5s ⏱️
  1 suites    0 💤
  1 files      0

Results for commit d976137.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 13, 2023

Orc8r Lint & Test

1 135 tests   1 135 ✔️  2m 10s ⏱️
   365 suites         0 💤
       7 files           0

Results for commit d976137.

♻️ This comment has been updated with latest results.

Copy link
Copy Markdown
Member

@maxhbr maxhbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jordanvrtanoski jordanvrtanoski enabled auto-merge (squash) June 26, 2023 04:13
@jordanvrtanoski jordanvrtanoski merged commit 094f6d7 into magma:master Jun 26, 2023
lucasgonze pushed a commit to lucasgonze/magma that referenced this pull request Feb 29, 2024
…on (magma#15001)

The issue magma#14995 is caused by a missing folder `alert_rules` in the prometheus configuration folder. The `alertmanager-configurer` will create the folder with restrictive access rights which will prevent `prometheus` and `alertmanager` to read the configuration.

Signed-off-by: Jordan Vrtanoski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: orc8r Orchestrator-related issue size/XS Denotes a PR that changes 0-9 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants