fix(agw): updated debian repo for 1.8.0 release by ShubhamTatvamasi · Pull Request #13824 · magma/magma

ShubhamTatvamasi · 2022-09-02T13:44:24Z

Signed-off-by: Shubham Tatvamasi [email protected]

Summary

Test Plan

Additional Information

This change is backwards-breaking

Signed-off-by: Shubham Tatvamasi <[email protected]>

github-actions · 2022-09-02T13:44:38Z

Thanks for opening a PR! 💯

A couple initial guidelines

All commits must be signed off. This is enforced by DCO check.
All PR titles must follow the semantic commits format. This is enforced by Semantic PR.

Howto

Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
Checks. All required CI checks must pass before merge.
Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

Contributing Conventions for norms around contributed code

If this is your first Magma PR, also consider reading

Developer Onboarding for onboarding as a new Magma developer
Development Workflow for guidance on your first pull request
CI Checks for points of contact for failing or flaky CI checks
GitHub-to-Slack mappings for Magma maintainers for guidance on how to contact maintainers on Slack

github-actions · 2022-09-02T13:54:53Z

feg-workflow

    2 files 203 suites 40s ⏱️
374 tests 374 ✔️ 0 💤 0 ❌
388 runs 388 ✔️ 0 💤 0 ❌

Results for commit 91a6566.

♻️ This comment has been updated with latest results.

Signed-off-by: Shubham Tatvamasi <[email protected]>

maxhbr · 2022-09-02T14:15:37Z

changes to hil_testing/Magma_Ansible/project/roles/upgrade-prep/tasks/main.yaml are not necessary, it is unused code

Signed-off-by: Shubham Tatvamasi <[email protected]>

github-actions · 2022-09-02T14:43:14Z

dp-workflow

15 tests 15 ✔️ 4m 37s ⏱️
  1 suites   0 💤
  1 files   0 ❌

Results for commit 91a6566.

♻️ This comment has been updated with latest results.

github-actions · 2022-09-02T14:46:20Z

cloud-workflow

1 000 tests 1 000 ✔️ 2m 9s ⏱️
  356 suites       0 💤
      7 files       0 ❌

Results for commit 91a6566.

♻️ This comment has been updated with latest results.

github-actions · 2022-09-02T15:23:19Z

agw-workflow

615 tests 611 ✔️ 4m 59s ⏱️
    2 suites     4 💤
    2 files     0 ❌

Results for commit 91a6566.

♻️ This comment has been updated with latest results.

maxhbr · 2022-09-02T15:47:31Z

On this branch the build for the gateway_c image failed: https://github.com/magma/magma/runs/8157992438?check_suite_focus=true

Signed-off-by: Shubham Tatvamasi <[email protected]>

m-govind · 2022-09-02T16:33:43Z

Looks good to me

ShubhamTatvamasi · 2022-09-02T16:33:46Z

changes to hil_testing/Magma_Ansible/project/roles/upgrade-prep/tasks/main.yaml are not necessary, it is unused code

Reverted this change.

m-govind · 2022-09-02T16:36:50Z

Looks good to me

ShubhamTatvamasi · 2022-09-02T18:46:12Z

On this branch the build for the gateway_c image failed: https://github.com/magma/magma/runs/8157992438?check_suite_focus=true

Build is fixed now.

jheidbrink · 2022-09-05T10:42:32Z

When building the agw_gateway_python container on this branch with an ARM instance, apt-get fails with

Unable to locate package bcc-tools

sebathomas · 2022-09-05T11:13:27Z

Strange, shouldn't it be this one?
https://artifactory.magmacore.org/ui/repos/tree/General/debian-prod%2Ffocal-1.8.0%2Fbcc-tools_0.23-1_arm64.deb

maxhbr · 2022-09-05T11:32:53Z

Strange, shouldn't it be this one? https://artifactory.magmacore.org/ui/repos/tree/General/debian-prod%2Ffocal-1.8.0%2Fbcc-tools_0.23-1_arm64.deb

it is missing relevant metadata in artifactory, also in debian-test.

LKreutzer · 2022-09-05T12:40:37Z

When building the agw_gateway_python container on this branch with an ARM instance, apt-get fails with

Unable to locate package bcc-tools

bcc-tools for arm64 had damaged property values for debian-test and debian. Removed respective files and re-uploaded with correct properties.

@jheidbrink please test again

jheidbrink · 2022-09-05T14:05:09Z

Looks good so far. The bazel build is still running, but bcc-tools installed fine.

crasu · 2022-09-06T13:25:46Z

@ShubhamTatvamasi do you have a green feg/lte integ test for this pr?

ShubhamTatvamasi · 2022-09-06T13:52:50Z

@ShubhamTatvamasi do you have a green feg/lte integ test for this pr?

I don't have any data on those tests.

sebathomas · 2022-09-06T14:11:58Z

You can run them on the branch in your fork if you enable Github Actions.

ShubhamTatvamasi · 2022-09-07T05:06:30Z

You can run them on the branch in your fork if you enable Github Actions.

Triggered both tests.

LTE integ test:
https://github.com/ShubhamTatvamasi/magma/actions/runs/3005169584

Federated integ test:
https://github.com/ShubhamTatvamasi/magma/actions/runs/3005170027

sebathomas · 2022-09-07T11:55:09Z

The LTE Integ Test looks good, I think the Federated Integ Test shows some problems in the agw-orc8r connection. Does anyone have an idea if it was green on v1.8 before? (Github seems to have some issues at the moment, hard to find out in the UI...)

crasu · 2022-09-07T16:04:10Z

The LTE Integ Test looks good, I think the Federated Integ Test shows some problems in the agw-orc8r connection. Does anyone have an idea if it was green on v1.8 before? (Github seems to have some issues at the moment, hard to find out in the UI...)

Yepp the LTE Integ Test only failed because it cannot upload its state to the website
@ShubhamTatvamasi Could you give the federated integ test another try?

ShubhamTatvamasi · 2022-09-07T17:20:06Z

The LTE Integ Test looks good, I think the Federated Integ Test shows some problems in the agw-orc8r connection. Does anyone have an idea if it was green on v1.8 before? (Github seems to have some issues at the moment, hard to find out in the UI...)

Yepp the LTE Integ Test only failed because it cannot upload its state to the website @ShubhamTatvamasi Could you give the federated integ test another try?

https://github.com/ShubhamTatvamasi/magma/actions/runs/3009501470

* fix(agw): updated debian repo for 1.8.0 release Signed-off-by: Shubham Tatvamasi <[email protected]> * updated debian repo on ansible scripts Signed-off-by: Shubham Tatvamasi <[email protected]> * updated focal repo Signed-off-by: Shubham Tatvamasi <[email protected]> * revert the code changes Signed-off-by: Shubham Tatvamasi <[email protected]> Signed-off-by: Shubham Tatvamasi <[email protected]>

fix(agw): updated debian repo for 1.8.0 release

744cc64

Signed-off-by: Shubham Tatvamasi <[email protected]>

ShubhamTatvamasi requested a review from a team September 2, 2022 13:44

ShubhamTatvamasi requested a review from a team as a code owner September 2, 2022 13:44

ShubhamTatvamasi requested review from a team, emakeev and talkhasib September 2, 2022 13:44

pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines. label Sep 2, 2022

github-actions bot added component: ci All updates on CI (Jenkins/CircleCi/Github Action) component: cwf component: feg FEG-gateway related issues component: orc8r Orchestrator-related issue labels Sep 2, 2022

updated debian repo on ansible scripts

3c9cede

Signed-off-by: Shubham Tatvamasi <[email protected]>

ShubhamTatvamasi requested a review from a team as a code owner September 2, 2022 13:56

ShubhamTatvamasi requested a review from ajahl September 2, 2022 13:56

pull-request-size bot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Sep 2, 2022

github-actions bot added the component: agw Access gateway-related issue label Sep 2, 2022

ShubhamTatvamasi requested a review from m-govind September 2, 2022 14:13