chore(dp): Remove apt packages version pinning in DP Dockerfiles#13769
Merged
xbend merged 1 commit intomagma:masterfrom Aug 29, 2022
Merged
chore(dp): Remove apt packages version pinning in DP Dockerfiles#13769xbend merged 1 commit intomagma:masterfrom
xbend merged 1 commit intomagma:masterfrom
Conversation
Signed-off-by: Tomasz Gromowski <[email protected]>
Contributor
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| FROM python:3.9.2-slim-buster as protos-generator | ||
|
|
||
| RUN apt-get update && apt-get install -y --no-install-recommends curl=7.64.0-4+deb10u2 zip=3.0-11+b1 make=4.2.1-1.2 unzip=6.0-23+deb10u2 | ||
| RUN apt-get update && apt-get install -y --no-install-recommends curl zip make unzip |
Contributor
| FROM python:3.9.2-slim-buster as protos-generator | ||
|
|
||
| RUN apt-get update && apt-get install -y --no-install-recommends curl=7.64.0-4+deb10u2 zip=3.0-11+b1 make=4.2.1-1.2 unzip=6.0-23+deb10u2 | ||
| RUN apt-get update && apt-get install -y --no-install-recommends curl zip make unzip |
Contributor
| FROM python:3.9.2-slim-buster as protos-generator | ||
|
|
||
| RUN apt-get update && apt-get install -y --no-install-recommends curl=7.64.0-4+deb10u2 zip=3.0-11+b1 make=4.2.1-1.2 unzip=6.0-23+deb10u2 | ||
| RUN apt-get update && apt-get install -y --no-install-recommends curl zip make unzip |
Contributor
Contributor
1 task
xbend
approved these changes
Aug 29, 2022
Contributor
xbend
left a comment
xbend
left a comment
There was a problem hiding this comment.
LGTM. Ignoring hadolint remarks, hard pinning versions is ok, but we can reply on distro packaging here. Versions are not pinned/specified but those are system packages that should not change much within base release of the image.
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
MagmaCIBot
pushed a commit
that referenced
this pull request
Aug 29, 2022
) Signed-off-by: Tomasz Gromowski <[email protected]> Signed-off-by: Tomasz Gromowski <[email protected]> (cherry picked from commit 77260f2)
maxhbr
pushed a commit
that referenced
this pull request
Aug 30, 2022
) (#13776) Signed-off-by: Tomasz Gromowski <[email protected]> Signed-off-by: Tomasz Gromowski <[email protected]> (cherry picked from commit 77260f2) Co-authored-by: Tomasz Gromowski <[email protected]>
rsarwad
pushed a commit
to rsarwad/magma
that referenced
this pull request
Sep 4, 2022
…ma#13769) Signed-off-by: Tomasz Gromowski <[email protected]> Signed-off-by: Tomasz Gromowski <[email protected]>
sklgromek
added a commit
to openEPC/magma
that referenced
this pull request
Sep 15, 2022
…ma#13769) Signed-off-by: Tomasz Gromowski <[email protected]> Signed-off-by: Tomasz Gromowski <[email protected]>
jordanvrtanoski
pushed a commit
to jordanvrtanoski/magma
that referenced
this pull request
Feb 8, 2023
…ma#13769) (magma#13776) Signed-off-by: Tomasz Gromowski <[email protected]> Signed-off-by: Tomasz Gromowski <[email protected]> (cherry picked from commit 77260f2) Co-authored-by: Tomasz Gromowski <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tomasz Gromowski [email protected]
Summary
To avoid dependency issues, when the base Docker image is updated, we shouldn't pin apt to a particular package version.
Test Plan
Additional Information