Skip to content

fix(agw): updated focal-ci to focal-1.8.0#13756

Merged
ShubhamTatvamasi merged 1 commit intomagma:v1.8from
ShubhamTatvamasi:upgrade-focal-to-focal-180
Sep 1, 2022
Merged

fix(agw): updated focal-ci to focal-1.8.0#13756
ShubhamTatvamasi merged 1 commit intomagma:v1.8from
ShubhamTatvamasi:upgrade-focal-to-focal-180

Conversation

@ShubhamTatvamasi
Copy link
Copy Markdown
Member

Signed-off-by: Shubham Tatvamasi [email protected]

Summary

Test Plan

Additional Information

  • This change is backwards-breaking

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Aug 26, 2022
@github-actions
Copy link
Copy Markdown
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Aug 26, 2022
@ShubhamTatvamasi ShubhamTatvamasi marked this pull request as ready for review August 26, 2022 13:33
@ShubhamTatvamasi ShubhamTatvamasi requested a review from a team August 26, 2022 13:33
@ShubhamTatvamasi ShubhamTatvamasi requested a review from a team as a code owner August 26, 2022 13:33
@github-actions
Copy link
Copy Markdown
Contributor

feg-workflow

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0
388 runs  388 ✔️ 0 💤 0

Results for commit bbff14c.

@Neudrino
Copy link
Copy Markdown
Contributor

It would probably be sensible to give details in the PR a summary, of what the impact is for the repository change in artifactory.
I believe there was some Slack discussions that the artifacts residing in those repositories might not be identical and some builds might change behaviour or do not work any longer.

As far as I understood from some Slack discussion @m-govind and @panyogesh are branch owners such that I added them as reviewers.

@github-actions
Copy link
Copy Markdown
Contributor

dp-workflow

15 tests   15 ✔️  4m 37s ⏱️
  1 suites    0 💤
  1 files      0

Results for commit bbff14c.

@github-actions
Copy link
Copy Markdown
Contributor

agw-workflow

615 tests   611 ✔️  3m 50s ⏱️
    2 suites      4 💤
    2 files        0

Results for commit bbff14c.

Copy link
Copy Markdown
Contributor

@jheidbrink jheidbrink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look reasonable to me. I agree with @Neudrino that a more verbose PR description would be helpful. I'm wondering if this still needs to be changed in more places (there are still references to focal-ci on the v1.8 branch).

@ShubhamTatvamasi ShubhamTatvamasi merged commit 32bff55 into magma:v1.8 Sep 1, 2022
wolfseb pushed a commit to wolfseb/magma that referenced this pull request Oct 3, 2022
Signed-off-by: Shubham Tatvamasi <[email protected]>

Signed-off-by: Shubham Tatvamasi <[email protected]>
jordanvrtanoski pushed a commit to jordanvrtanoski/magma that referenced this pull request Feb 8, 2023
Signed-off-by: Shubham Tatvamasi <[email protected]>

Signed-off-by: Shubham Tatvamasi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/XS Denotes a PR that changes 0-9 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants