Skip to content

fix(pipelined): Updating pipelined production configuration#13656

Merged
koolzz merged 4 commits intomagma:masterfrom
mehul-jindal:pipelinedProdConfig
Aug 19, 2022
Merged

fix(pipelined): Updating pipelined production configuration#13656
koolzz merged 4 commits intomagma:masterfrom
mehul-jindal:pipelinedProdConfig

Conversation

@mehul-jindal
Copy link
Copy Markdown
Contributor

Signed-off-by: mehul-jindal-wavelabs [email protected]

Summary

Added missing pipelined configuration in production yml file.

Test Plan

Additional Information

@mehul-jindal mehul-jindal requested a review from a team as a code owner August 18, 2022 12:26
@mehul-jindal mehul-jindal requested review from a team, crasu and koolzz August 18, 2022 12:26
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines. label Aug 18, 2022
@github-actions
Copy link
Copy Markdown
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added component: agw Access gateway-related issue component: cwf labels Aug 18, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 18, 2022

feg-workflow

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0
388 runs  388 ✔️ 0 💤 0

Results for commit 7195611.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 18, 2022

dp-workflow

13 tests   13 ✔️  2m 6s ⏱️
  1 suites    0 💤
  1 files      0

Results for commit 7195611.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 18, 2022

agw-workflow

615 tests   611 ✔️  3m 50s ⏱️
    2 suites      4 💤
    2 files        0

Results for commit 7195611.

♻️ This comment has been updated with latest results.

ovs_gtp_stats_polling_interval: 180

# Make as a True when gnb ip will support for uplink
ovs_multi_tunnel: False
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please check if without 'ovs_multi_tunnel' things are working. Is it a must needed.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This flag is used whenever uplink flow is added in ovs.

ovs_multi_tunnel: False
# Paging timeout value
paging_timeout: 30
classifier_controller_id: 5
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put some comments for more information about the variables.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also lets make sure these parameters are explained in the Documents.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, we'll explain these parameters in documents.

@mehul-jindal mehul-jindal requested a review from panyogesh August 19, 2022 08:22
Copy link
Copy Markdown
Contributor

@koolzz koolzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@koolzz koolzz merged commit a3abb2a into magma:master Aug 19, 2022
@panyogesh panyogesh added type: bug Something isn't working priority: medium Medium priority bug product: 5g sa labels Aug 19, 2022
MagmaCIBot pushed a commit that referenced this pull request Aug 22, 2022
* fix(pipelined): Updating pipelined production configuration

Signed-off-by: mehul-jindal-wavelabs <[email protected]>

* fix(pipelined): Updating pipelined production configuration

Signed-off-by: mehul-jindal-wavelabs <[email protected]>

* fix(pipelined): Updating pipelined production configuration

Signed-off-by: mehul-jindal-wavelabs <[email protected]>

* fix(pipelined): Updating pipelined production configuration

Signed-off-by: mehul-jindal-wavelabs <[email protected]>

Signed-off-by: mehul-jindal-wavelabs <[email protected]>
Co-authored-by: Sebastian Thomas <[email protected]>
(cherry picked from commit a3abb2a)
@MagmaCIBot
Copy link
Copy Markdown

💚 All backports created successfully

Status Branch Result
v1.8

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

tmdzk pushed a commit that referenced this pull request Aug 24, 2022
…13676)

* fix(pipelined): Updating pipelined production configuration

Signed-off-by: mehul-jindal-wavelabs <[email protected]>

* fix(pipelined): Updating pipelined production configuration

Signed-off-by: mehul-jindal-wavelabs <[email protected]>

* fix(pipelined): Updating pipelined production configuration

Signed-off-by: mehul-jindal-wavelabs <[email protected]>

* fix(pipelined): Updating pipelined production configuration

Signed-off-by: mehul-jindal-wavelabs <[email protected]>

Signed-off-by: mehul-jindal-wavelabs <[email protected]>
Co-authored-by: Sebastian Thomas <[email protected]>
(cherry picked from commit a3abb2a)

Co-authored-by: Mehul Jindal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backported-v1.8 component: agw Access gateway-related issue priority: medium Medium priority bug product: 5g sa size/S Denotes a PR that changes 10-29 lines. type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants