Skip to content

fix: sentry_sdk is pinned to <1.9#13652

Merged
nstng merged 1 commit intomagma:masterfrom
nstng:fix_py_sentry_sdk_dependency
Aug 18, 2022
Merged

fix: sentry_sdk is pinned to <1.9#13652
nstng merged 1 commit intomagma:masterfrom
nstng:fix_py_sentry_sdk_dependency

Conversation

@nstng
Copy link
Copy Markdown
Contributor

@nstng nstng commented Aug 18, 2022 •
edited
Loading

Signed-off-by: Nils Semmelrock [email protected]

Summary

see #13645

Test Plan

Additional Information

  • This change is backwards-breaking

@nstng
fix: sentry_sdk is pinned to <1.9
23db99f 
Signed-off-by: Nils Semmelrock <[email protected]>
@nstng nstng requested a review from a team as a code owner August 18, 2022 09:42
@nstng nstng requested review from a team, ajahl and sebathomas August 18, 2022 09:42
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Aug 18, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 18, 2022

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added component: agw Access gateway-related issue component: orc8r Orchestrator-related issue labels Aug 18, 2022
@nstng nstng linked an issue Aug 18, 2022 that may be closed by this pull request
Python version issue observed while running checkin_cli.py script with containerized AGW #13645
Closed
@nstng nstng mentioned this pull request Aug 18, 2022
Closed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 18, 2022

feg-workflow

    2 files  203 suites   39s ⏱️
374 tests 374 ✔️ 0 💤 0 ❌
388 runs  388 ✔️ 0 💤 0 ❌

Results for commit 23db99f.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 18, 2022

dp-workflow

13 tests   13 ✔️  2m 3s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 23db99f.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 18, 2022 •
edited
Loading

cloud-workflow

1 009 tests   1 009 ✔️  2m 26s ⏱️
   356 suites         0 💤
       7 files           0 ❌

Results for commit 23db99f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 18, 2022

agw-workflow

615 tests   611 ✔️  5m 2s ⏱️
    2 suites      4 💤
    2 files        0 ❌

Results for commit 23db99f.

@nstng nstng merged commit 2e1f16f into magma:master Aug 18, 2022
@maxhbr
Copy link
Copy Markdown
Member

maxhbr commented Aug 23, 2022

why does #13652 need to be backported?

@sebathomas
Copy link
Copy Markdown
Contributor

sebathomas commented Aug 23, 2022

If I remember correctly, the dockerized agw was broken without this change because pip would select incompatible versions of packages. We didn't have this problem in the pydep release.

@MagmaCIBot MagmaCIBot mentioned this pull request Aug 24, 2022
Merged
MagmaCIBot pushed a commit that referenced this pull request Aug 24, 2022
@nstng
fix: sentry_sdk is pinned to <1.9 (#13652)
b785a26 
Signed-off-by: Nils Semmelrock <[email protected]>

Signed-off-by: Nils Semmelrock <[email protected]>
(cherry picked from commit 2e1f16f)
@MagmaCIBot
Copy link
Copy Markdown

MagmaCIBot commented Aug 24, 2022

💚 All backports created successfully

Status Branch Result
✅ v1.8

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

tmdzk pushed a commit that referenced this pull request Aug 24, 2022
@MagmaCIBot @nstng
fix: sentry_sdk is pinned to <1.9 (#13652) (#13720)
a8886ad 
Signed-off-by: Nils Semmelrock <[email protected]>

Signed-off-by: Nils Semmelrock <[email protected]>
(cherry picked from commit 2e1f16f)

Co-authored-by: Nils Semmelrock <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sebathomas sebathomas sebathomas approved these changes

@ajahl ajahl Awaiting requested review from ajahl ajahl was automatically assigned from magma/approvers-agw

Assignees

No one assigned

Labels

backported-v1.8 component: agw Access gateway-related issue component: orc8r Orchestrator-related issue size/XS Denotes a PR that changes 0-9 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Python version issue observed while running checkin_cli.py script with containerized AGW

5 participants

@nstng @maxhbr @sebathomas @MagmaCIBot @tmdzk