docs: Extended features in 5G SA documentation#13624
Merged
panyogesh merged 3 commits intomagma:masterfrom Aug 26, 2022
Merged
Conversation
Contributor
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
Contributor
sreedharkumartn
force-pushed
the
topic/sreedhar/Extended_5G_SA_features
branch
2 times, most recently
from
003aa69 to
c9e07a0
Compare
pull-request-size
bot
added
size/L
sreedharkumartn
force-pushed
the
topic/sreedhar/Extended_5G_SA_features
branch
2 times, most recently
from
f07f430 to
185e6cf
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
|
Oops! Looks like you failed the Howto
♻️ Updated: ✅ The check is passing the Markdown lint check after the last commit. |
sreedharkumartn
force-pushed
the
topic/sreedhar/Extended_5G_SA_features
branch
4 times, most recently
from
9c5c09a to
3686d23
Compare
ganeshg87
reviewed
Aug 19, 2022
sreedharkumartn
force-pushed
the
topic/sreedhar/Extended_5G_SA_features
branch
2 times, most recently
from
610551a to
8aef868
Compare
Neudrino
reviewed
Aug 23, 2022
Contributor
Neudrino
left a comment
Neudrino
left a comment
There was a problem hiding this comment.
Thanks for the documentation contribution.
There are some formal aspects which need to be corrected.
In general it would be good, if for any abbreviations used in the document the long form would be given on first occurance.
|
|
||
| Magma 5G SA feature enables operators to provide enhanced Mobile Broadband services and opens up new opportunities for business. | ||
|
|
||
| This document gives an overview of the Extended features added on top of [integrated 5G SA](https://docs.magmacore.org/docs/lte/integrated_5g_sa) such as 5G QoS, IPv6 & Dual IPv4v6 support, Network initiated Session Modification, SUCI Extensions, Stateless feature and GTP extension header support. |
Contributor
There was a problem hiding this comment.
- You could add relative links to the paragraphs in your list of features.
- You might want to consider a list instead. Kind of a table of contents.
Contributor
Author
There was a problem hiding this comment.
Addressed Review Comment
sreedharkumartn
force-pushed
the
topic/sreedhar/Extended_5G_SA_features
branch
from
8aef868 to
85424b7
Compare
Neudrino
previously approved these changes
Aug 24, 2022
Contributor
Neudrino
left a comment
Neudrino
left a comment
There was a problem hiding this comment.
Thanks a lot for all the corrections! 👍 ➡️ Good to go for me.
Signed-off-by: sreedharkumartn <[email protected]>
Signed-off-by: sreedharkumartn <[email protected]>
sreedharkumartn
force-pushed
the
topic/sreedhar/Extended_5G_SA_features
branch
from
85424b7 to
e124066
Compare
Signed-off-by: sreedharkumartn <[email protected]>
sreedharkumartn
force-pushed
the
topic/sreedhar/Extended_5G_SA_features
branch
from
e124066 to
f211fc4
Compare
Contributor
Author
|
Hai @Neudrino, the linters are fixed and please review the updated PR. |
Neudrino
approved these changes
Aug 26, 2022
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
MagmaCIBot
pushed a commit
that referenced
this pull request
Aug 28, 2022
* docs: Extended features in 5G SA documentation Signed-off-by: sreedharkumartn <[email protected]> * Addressed Review Comments (R1) Signed-off-by: sreedharkumartn <[email protected]> * Review (R2) Signed-off-by: sreedharkumartn <[email protected]> Signed-off-by: sreedharkumartn <[email protected]> (cherry picked from commit 24a00c4)
maxhbr
pushed a commit
that referenced
this pull request
Aug 30, 2022
force merged, as wanted by Yogesh Pandey * docs: Extended features in 5G SA documentation Signed-off-by: sreedharkumartn <[email protected]> * Addressed Review Comments (R1) Signed-off-by: sreedharkumartn <[email protected]> * Review (R2) Signed-off-by: sreedharkumartn <[email protected]> Signed-off-by: sreedharkumartn <[email protected]> (cherry picked from commit 24a00c4) Co-authored-by: T N Sreedhar Kumar <[email protected]>
rsarwad
pushed a commit
to rsarwad/magma
that referenced
this pull request
Sep 4, 2022
* docs: Extended features in 5G SA documentation Signed-off-by: sreedharkumartn <[email protected]> * Addressed Review Comments (R1) Signed-off-by: sreedharkumartn <[email protected]> * Review (R2) Signed-off-by: sreedharkumartn <[email protected]> Signed-off-by: sreedharkumartn <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: sreedharkumartn [email protected]
Summary
Documentation for Extended features in 5G SA
Test Plan
Screenshots of the Documentation
Additional Information